From: Roman Gushchin <guro@fb.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Aslan Bakirov <aslan@fb.com>, <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<kernel-team@fb.com>, <riel@surriel.com>, <mhocko@kernel.org>,
<hannes@cmpxchg.org>
Subject: Re: [PATCH 1/2] mm: cma: NUMA node interface
Date: Fri, 3 Apr 2020 08:09:53 -0700 [thread overview]
Message-ID: <20200403030424.GA220160@carbon.lan> (raw)
In-Reply-To: <65164fdb-38b0-e239-84cc-ab22b92214c5@suse.cz>
On Thu, Apr 02, 2020 at 05:48:00PM +0200, Vlastimil Babka wrote:
> On 3/26/20 10:27 PM, Aslan Bakirov wrote:
> > I've noticed that there is no interfaces exposed by CMA which would let me
> > to declare contigous memory on particular NUMA node.
> >
> > This patchset adds the ability to try to allocate contiguous memory on
> > specific node.
Hello, Vlastimil!
>
> I would say more explicitly that 'try' here means it will fallback to other
> nodes if the specific one doesn't work. At least AFAICS that's what it does by
> calling memblock_alloc_range_nid() with exact_nid=false.
Hm, maybe we need exact_nid=true for this case? The whole point here is to
have a per-node cma zone, so if it's not possible to allocate one on the
specific node, maybe it's better to just skip it?
>
> > Implement a new method for declaring contigous memory on particular node
> > and keep cma_declare_contiguous() as a wrapper.
>
> Should there be also support for using this node spcification in the cma=X boot
> param?
I'd wait for a first real usecase. It's fairly easy to add one, and very hard to remove,
so I'd be conservative here.
Also, in the future we might want to allocate it automatically and shrink on demand.
Btw, thank you very much for gathering all patches for Michal.
Thanks!
next prev parent reply other threads:[~2020-04-03 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 21:27 [PATCH 1/2] mm: cma: NUMA node interface Aslan Bakirov
2020-03-26 21:27 ` [PATCH 2/2] mm: hugetlb: Use node interface of cma Aslan Bakirov
2020-03-27 8:06 ` Michal Hocko
2020-03-27 14:41 ` Roman Gushchin
2020-03-27 15:13 ` Michal Hocko
2020-04-02 15:20 ` Vlastimil Babka
2020-04-02 17:24 ` Michal Hocko
2020-03-27 8:02 ` [PATCH 1/2] mm: cma: NUMA node interface Michal Hocko
2020-04-02 15:48 ` Vlastimil Babka
2020-04-02 22:03 ` Aslan Bakirov
2020-04-03 15:09 ` Roman Gushchin [this message]
2020-04-03 10:18 Aslan Bakirov
2020-04-03 11:18 Aslan Bakirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403030424.GA220160@carbon.lan \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=aslan@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).