From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87AB5C2BA15 for ; Sat, 4 Apr 2020 18:52:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17FE5206C3 for ; Sat, 4 Apr 2020 18:52:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eEawZWJ2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17FE5206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 742658E000A; Sat, 4 Apr 2020 14:52:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2D08E0009; Sat, 4 Apr 2020 14:52:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E1028E000A; Sat, 4 Apr 2020 14:52:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 422C28E0009 for ; Sat, 4 Apr 2020 14:52:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F2266180AD81D for ; Sat, 4 Apr 2020 18:52:38 +0000 (UTC) X-FDA: 76671068796.04.eyes75_3430f3ce0360d X-HE-Tag: eyes75_3430f3ce0360d X-Filterd-Recvd-Size: 3498 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Sat, 4 Apr 2020 18:52:38 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id g27so10329556ljn.10 for ; Sat, 04 Apr 2020 11:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hBMXqhkR3Bd5JwVi0rinAAJBGM9rUC/9TzS2AavdsaE=; b=eEawZWJ2ayk08oPbswgZWuozx6Ijh+Ywg9oScIkGbDjhxGyhf1oVbDqIqrcTpJA988 a1q6xo0g9jvs8M6iIEvzHndqLyuf7sQN8764oNTZJK8P+OPFviBgefcAKYHY8JAmq2zV SpxyQ1rpaZK0RZUGG1neWz9nlbgANMmhF/ns9775kmnWxwzWpE0GA76KeatKo1UgD45o AXo9A2vijGJ8uCiaUrPZ/DPZoBO6y3xTWQvtTpzioRnl7ZGSZMqHQIgjSChGb2xIkAtK suUFx3iJG+ohi+AkhWjqQ+LmLNq7yYGaJ952fAUgiWDKq/6F6JgaxHQflI37oeFP1/I9 PoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hBMXqhkR3Bd5JwVi0rinAAJBGM9rUC/9TzS2AavdsaE=; b=QAobHDyifpJdrIX0qIGxWayTkmxcRa89Ac8T0nJTqQQluXx0J22QWk7z8o4RKe9f5v Xp2gg++MNDd8gRDcgjxHwnf7ZaTsJ6rnbTsi/8gubQs1QgX2IKMr373Tf0p5PJsSbIWO y2Hr888iMxZKjdLgvh4aRGEjcPVs9bhdwtsJjfUpXKIOaz04H/JeVnUkD3NLAKRJnYSs fo+zRXceEtPnBUaRDccrXIvjbDJU6IL0Px/UM/zqXF9m8ojyCR6iJXVbctMROBJ5FoF1 sFRRj9tOQ1NDijqG2MGh4ko1Y8mciUqqWkqC669AEr/aIunA/6qzkKwpOp5shFfujuN2 unTg== X-Gm-Message-State: AGi0PubK9v3nEdrELtbCcMs0RdfBJdIzOBTt0AyYJgQ8zdGJknNisA7f 7sbvLtMPLdPC1nnZdVu+F7E= X-Google-Smtp-Source: APiQypJY7Z0bBl4GHlSA43yOpOdCsc++txL/kR5eOW2aOEE1Yew08Ncwu2teYb1M97/7lyo5CFz26Q== X-Received: by 2002:a2e:998c:: with SMTP id w12mr8197378lji.57.1586026357027; Sat, 04 Apr 2020 11:52:37 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id o2sm7293546ljm.2.2020.04.04.11.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2020 11:52:36 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sat, 4 Apr 2020 20:52:29 +0200 To: William Kucharski Cc: Peter Zijlstra , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, jroedel@suse.de, vbabka@suse.cz, urezki@gmail.com, Thomas Gleixner Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments Message-ID: <20200404185229.GA424@pc636> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > =EF=BB=BFIs there any need to similarly sanitize =E2=80=9Csize=E2=80=9D= to assure start + size doesn=E2=80=99t go past =E2=80=9Cend?=E2=80=9D >=20 Why is that double check needed if all such tests are done deeper on stac= k? -- Vlad Rezki