From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3080FC2BA19 for ; Mon, 6 Apr 2020 10:57:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F0E7120678 for ; Mon, 6 Apr 2020 10:57:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0E7120678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 84D7D8E000E; Mon, 6 Apr 2020 06:57:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FD8F8E000D; Mon, 6 Apr 2020 06:57:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 713DD8E000E; Mon, 6 Apr 2020 06:57:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 5BCF38E000D for ; Mon, 6 Apr 2020 06:57:27 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 16AB24995EF for ; Mon, 6 Apr 2020 10:57:27 +0000 (UTC) X-FDA: 76677128934.23.beast45_5e1dd1548f35d X-HE-Tag: beast45_5e1dd1548f35d X-Filterd-Recvd-Size: 6984 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 10:57:26 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id h2so6198328wmb.4 for ; Mon, 06 Apr 2020 03:57:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g5mY/6j+QCbr50e5xP/QNFLfFi9SvIAJHD7FGYbPvOI=; b=bhL3BdlGbdZKrSqqKzeGq+nqctcHdtKfBOlb4vjf1VPT8KQuM22Ty4nx5Xh4liQ5Qs mw/wZ5E2F6sn0wKWKcs72GQKR7o/vj1kX8sSS4TG0Kj4B8UpNbaUWXD593Pc3Hn6oO0a GShy4p7UYbsY8HvUIv8AS//jxWz1CYUsHaY47L1IhBUTe6jIBD9I2wBmFE+i0cIGFtlK odNnxc6YYDzcza6bcFtYqIAvDtZJTfeU1VQpECvig+u0SgCsMdO7Wb2Rie3fKFB3iGB/ CkeAeZeF3XodxhgwP7ApPyrSjMPLv8ezrRNDypdgZlZxqqeZ9EWmwGMKP63z4Lwcwf2e i+Hw== X-Gm-Message-State: AGi0PuZ84At0TyY+Qd/kKOJCb8MRgMNcklN6VMWBqv3zkkS9hl0qqG4o p8jUrp1GVYRGOBQXuXOw3dI= X-Google-Smtp-Source: APiQypLI2VKCrb+awtZriktURlgTQ9LBJ2jKntQWFaLBR48f6AeEwpIjCggmXhacyVJA38rFQc9SrA== X-Received: by 2002:a7b:cb13:: with SMTP id u19mr4747173wmj.132.1586170645555; Mon, 06 Apr 2020 03:57:25 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id a2sm17369883wra.71.2020.04.06.03.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 03:57:24 -0700 (PDT) Date: Mon, 6 Apr 2020 12:57:23 +0200 From: Michal Hocko To: Jan Kara Cc: NeilBrown , Trond Myklebust , "Anna.Schumaker@Netapp.com" , Andrew Morton , linux-mm@kvack.org, linux-nfs@vger.kernel.org, LKML Subject: Re: [PATCH 1/2] MM: replace PF_LESS_THROTTLE with PF_LOCAL_THROTTLE Message-ID: <20200406105723.GM19426@dhcp22.suse.cz> References: <87tv2b7q72.fsf@notabene.neil.brown.name> <87v9miydai.fsf@notabene.neil.brown.name> <87sghmyd8v.fsf@notabene.neil.brown.name> <20200403151534.GG22681@dhcp22.suse.cz> <878sjcxn7i.fsf@notabene.neil.brown.name> <20200406074453.GH19426@dhcp22.suse.cz> <20200406093601.GA1143@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200406093601.GA1143@quack2.suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 06-04-20 11:36:01, Jan Kara wrote: > On Mon 06-04-20 09:44:53, Michal Hocko wrote: > > On Sat 04-04-20 08:40:17, Neil Brown wrote: > > > On Fri, Apr 03 2020, Michal Hocko wrote: > > > > > > > On Thu 02-04-20 10:53:20, Neil Brown wrote: > > > >> > > > >> PF_LESS_THROTTLE exists for loop-back nfsd, and a similar need in the > > > >> loop block driver, where a daemon needs to write to one bdi in > > > >> order to free up writes queued to another bdi. > > > >> > > > >> The daemon sets PF_LESS_THROTTLE and gets a larger allowance of dirty > > > >> pages, so that it can still dirty pages after other processses have been > > > >> throttled. > > > >> > > > >> This approach was designed when all threads were blocked equally, > > > >> independently on which device they were writing to, or how fast it was. > > > >> Since that time the writeback algorithm has changed substantially with > > > >> different threads getting different allowances based on non-trivial > > > >> heuristics. This means the simple "add 25%" heuristic is no longer > > > >> reliable. > > > >> > > > >> This patch changes the heuristic to ignore the global limits and > > > >> consider only the limit relevant to the bdi being written to. This > > > >> approach is already available for BDI_CAP_STRICTLIMIT users (fuse) and > > > >> should not introduce surprises. This has the desired result of > > > >> protecting the task from the consequences of large amounts of dirty data > > > >> queued for other devices. > > > > > > > > While I understand that you want to have per bdi throttling for those > > > > "special" files I am still missing how this is going to provide the > > > > additional room that the additnal 25% gave them previously. I might > > > > misremember or things have changed (what you mention as non-trivial > > > > heuristics) but PF_LESS_THROTTLE really needed that room to guarantee a > > > > forward progress. Care to expan some more on how this is handled now? > > > > Maybe we do not need it anymore but calling that out explicitly would be > > > > really helpful. > > > > > > The 25% was a means to an end, not an end in itself. > > > > > > The problem is that the NFS server needs to be able to write to the > > > backing filesystem when the dirty memory limits have been reached by > > > being totally consumed by dirty pages on the NFS filesystem. > > > > > > The 25% was just a way of giving an allowance of dirty pages to nfsd > > > that could not be consumed by processes writing to an NFS filesystem. > > > i.e. it doesn't need 25% MORE, it needs 25% PRIVATELY. Actually it only > > > really needs 1 page privately, but a few pages give better throughput > > > and 25% seemed like a good idea at the time. > > > > Yes this part is clear to me. > > > > > per-bdi throttling focuses on the "PRIVATELY" (the important bit) and > > > de-emphasises the 25% (the irrelevant detail). > > > > It is still not clear to me how this patch is going to behave when the > > global dirty throttling is essentially equal to the per-bdi - e.g. there > > is only a single bdi and now the PF_LOCAL_THROTTLE process doesn't have > > anything private. > > Let me think out loud so see whether I understand this properly. There are > two BDIs involved in NFS loop mount - the NFS virtual BDI (let's call it > simply NFS-bdi) and the bdi of the real filesystem that is backing NFS > (let's call this real-bdi). The case we are concerned about is when NFS-bdi > is full of dirty pages so that global dirty limit of the machine is > exceeded. Then flusher thread will take dirty pages from NFS-bdi and send > them over localhost to nfsd. Nfsd, which has PF_LOCAL_THROTTLE set, will take > these pages and write them to real-bdi. Now because PF_LOCAL_THROTTLE is > set for nfsd, the fact that we are over global limit does not take effect > and nfsd is still able to write to real-bdi until dirty limit on real-bdi > is reached. So things should work as Neil writes AFAIU. Thanks for the clarification. I was not aware of the 2 bdi situation. This makes more sense now. Maybe this is a trivial fact for everybody who is more familiar with nfs internals but it would be so much esier to follow if it was explicit in the changelog. -- Michal Hocko SUSE Labs