From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6591CC2BA19 for ; Mon, 6 Apr 2020 11:58:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 236702072A for ; Mon, 6 Apr 2020 11:58:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 236702072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7D0528E000E; Mon, 6 Apr 2020 07:58:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 782488E000D; Mon, 6 Apr 2020 07:58:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BE4E8E000E; Mon, 6 Apr 2020 07:58:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id 56AA58E000D for ; Mon, 6 Apr 2020 07:58:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1C68480186DC for ; Mon, 6 Apr 2020 11:58:20 +0000 (UTC) X-FDA: 76677282360.28.uncle23_2b7d558b4cf5c X-HE-Tag: uncle23_2b7d558b4cf5c X-Filterd-Recvd-Size: 1785 Received: from r3-25.sinamail.sina.com.cn (r3-25.sinamail.sina.com.cn [202.108.3.25]) by imf03.hostedemail.com (Postfix) with SMTP for ; Mon, 6 Apr 2020 11:58:18 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.246.227.120]) by sina.com with ESMTP id 5E8B195500019C5B; Mon, 6 Apr 2020 19:58:15 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 66357754919617 From: Hillf Danton To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Vlastimil Babka , Mel Gorman Subject: Re: [PATCH v5 05/10] mm/swap: charge the page when adding to the swap cache Date: Mon, 6 Apr 2020 19:58:04 +0800 Message-Id: <20200406115804.4440-1-hdanton@sina.com> In-Reply-To: <1585892447-32059-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1585892447-32059-1-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000057, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Apr 2020 14:40:43 +0900 Joonsoo Kim wrote: >=20 > @@ -153,11 +165,16 @@ int add_to_swap_cache(struct page *page, swp_entr= y_t entry, > xas_unlock_irq(&xas); > } while (xas_nomem(&xas, gfp)); > =20 > - if (!xas_error(&xas)) > + if (!xas_error(&xas)) { > + mem_cgroup_commit_charge(page, memcg, false, compound); Add a tp=20 trace_mm_add_to_swap_cache(page); > return 0; > + } > + > + mem_cgroup_cancel_charge(page, memcg, compound); > =20 > ClearPageSwapCache(page); > page_ref_sub(page, nr); > + > return xas_error(&xas); > }