From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF9C2C2BA1A for ; Tue, 7 Apr 2020 01:55:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 80B9120644 for ; Tue, 7 Apr 2020 01:55:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DoL7mK9P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80B9120644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1FFBE8E0005; Mon, 6 Apr 2020 21:55:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B0D68E0001; Mon, 6 Apr 2020 21:55:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C6628E0005; Mon, 6 Apr 2020 21:55:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EACD58E0001 for ; Mon, 6 Apr 2020 21:55:41 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A6CB353B3 for ; Tue, 7 Apr 2020 01:55:41 +0000 (UTC) X-FDA: 76679392482.14.blow90_4ec2fb0114a10 X-HE-Tag: blow90_4ec2fb0114a10 X-Filterd-Recvd-Size: 5293 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 01:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586224540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=en6m2z2EnLXafQKpsnYmfSMGIZ9fcWYqpiFOBe1+leI=; b=DoL7mK9Pc5QSEMGjydBn9u0PYZgHbHsCHhw+zmMWccdF562ZJSNojZmTfmUR90roXM74v1 zxhYbBVXYMkCPIfYS1Cm9KUl7ulfKp1bkhUo/lEgt3mC1bRDXNahPG1kA0iafQSHObktea OLB63Sm+d6Cry8wemMQvIYronQNTquQ= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-498-9rDUXe1cM2SHicoVPYTfTw-1; Mon, 06 Apr 2020 21:55:38 -0400 X-MC-Unique: 9rDUXe1cM2SHicoVPYTfTw-1 Received: by mail-qt1-f199.google.com with SMTP id b3so1754159qte.13 for ; Mon, 06 Apr 2020 18:55:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oItCj2q8YHb63ZBfFyBFQkDD3U/LJfbIS9cHzfIZ+kg=; b=QK37edXArMUn/aFIld6W33e0I7sla4WwWyny2d3S7LxKRugj98gijyhWyitNw04NaG yK4XcFbmFNGJpdrA5V3AOdOb21sHI/0aakO/qVfoFTj9068gKbpHb2y5PVdKHPm0PklD wrdQ5an5PFAy3TRdUWKoo3psSvDwf/Unc2sQWH3OhtNuvkl5kKljWk/I0r9LhZfY4NcO +6CaD/5Iyk9qaQNVP/P6t4JZpGLh4UFDAzwuTnINRY+Xvydw12bq33BpaIHWbIsCdtap mH2No0AFCcWTHUds0NxHw8I6gPVP+U9Sj6o7UHeKmWvNVh+j4W7anFq6hJV9hrIz24+L tT7Q== X-Gm-Message-State: AGi0PuZOHDQU8q3dx2ORHhywF9lfTmGCc8dpG2UIZatNP4tzV7henSSo AHDaEy21L7H7WiFvJVWJzxYlpYMGCkJF0Nmm+pQbHSHrDapyblOIcgueTZLtcRtNJtxk3DPKmoa 6cCmSCW2kruw= X-Received: by 2002:ac8:4d8b:: with SMTP id a11mr143481qtw.391.1586224538185; Mon, 06 Apr 2020 18:55:38 -0700 (PDT) X-Google-Smtp-Source: APiQypK+gNlV/6Oyl3ckqIUc2Hc29srtoZnCqrcc5MKHtt+qWVWRdKpz+NvsF8oAGL3g8gWu3juB0g== X-Received: by 2002:ac8:4d8b:: with SMTP id a11mr143461qtw.391.1586224537863; Mon, 06 Apr 2020 18:55:37 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::3]) by smtp.gmail.com with ESMTPSA id c6sm13998002qkg.88.2020.04.06.18.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 18:55:37 -0700 (PDT) Date: Mon, 6 Apr 2020 21:55:35 -0400 From: Peter Xu To: Andrew Morton Cc: syzbot , bgeffon@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, torvalds@linux-foundation.org Subject: Re: BUG: unable to handle kernel paging request in kernel_get_mempolicy Message-ID: <20200407015535.GC48345@xz-x1> References: <0000000000002b25f105a2a3434d@google.com> <20200407004745.GA48345@xz-x1> <20200406183941.38a2e52026e42dbfde239a56@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20200406183941.38a2e52026e42dbfde239a56@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 06, 2020 at 06:39:41PM -0700, Andrew Morton wrote: > On Mon, 6 Apr 2020 20:47:45 -0400 Peter Xu wrote: >=20 > > >From 23800bff6fa346a4e9b3806dc0cfeb74498df757 Mon Sep 17 00:00:00 2001 > > From: Peter Xu > > Date: Mon, 6 Apr 2020 20:40:13 -0400 > > Subject: [PATCH] mm/mempolicy: Allow lookup_node() to handle fatal sign= al > >=20 > > lookup_node() uses gup to pin the page and get node information. It > > checks against ret>=3D0 assuming the page will be filled in. However > > it's also possible that gup will return zero, for example, when the > > thread is quickly killed with a fatal signal. Teach lookup_node() to > > gracefully return an error -EFAULT if it happens. > >=20 > > ... > > > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -902,7 +902,10 @@ static int lookup_node(struct mm_struct *mm, unsig= ned long addr) > > =20 > > =09int locked =3D 1; > > =09err =3D get_user_pages_locked(addr & PAGE_MASK, 1, 0, &p, &locked); > > -=09if (err >=3D 0) { > > +=09if (err =3D=3D 0) { > > +=09=09/* E.g. GUP interupted by fatal signal */ > > +=09=09err =3D -EFAULT; > > +=09} else if (err > 0) { > > =09=09err =3D page_to_nid(p); > > =09=09put_page(p); > > =09} >=20 > Doh. Thanks. >=20 > Should it have been -EINTR? It looks ok to me too. I was returning -EFAULT to follow the same value as get_vaddr_frames() (which is the other caller of get_user_pages_locked()). So far the only path that I found can trigger this is when there's a fatal signal pending right after the gup. If so, the userspace won't have a chance to see the -EINTR (or whatever we return) anyways. Thanks, --=20 Peter Xu