From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D4CC2BA80 for ; Tue, 7 Apr 2020 03:07:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5D0F20801 for ; Tue, 7 Apr 2020 03:07:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ud6KO3UB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5D0F20801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 943588E004E; Mon, 6 Apr 2020 23:07:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CB808E0001; Mon, 6 Apr 2020 23:07:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E1D48E004E; Mon, 6 Apr 2020 23:07:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 625088E0001 for ; Mon, 6 Apr 2020 23:07:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 27E69180AD806 for ; Tue, 7 Apr 2020 03:07:56 +0000 (UTC) X-FDA: 76679574552.07.knife81_7f754f5536a56 X-HE-Tag: knife81_7f754f5536a56 X-Filterd-Recvd-Size: 2592 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 03:07:55 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC58C21974; Tue, 7 Apr 2020 03:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586228875; bh=ZKzrgsXjqBXRYxWQB41mn+XyBTOuarqXHhYCoSlgKXs=; h=Date:From:To:Subject:In-Reply-To:From; b=ud6KO3UBbPgqO5zlGngjMRiZ3QivCBDKQaPGg7QB6dK/TRBAHbGhSAOdcr7/8Rjvr bZZ9sxVsk+I+cM/0f5ZaoBpNPQKWKWw214UBHyH+Of6tjmrOkYf15dAQ8Tl3nCmL75 1Lj6d9BgEmpVyXc5RwYKU048U2lsGi+YspHjVGyE= Date: Mon, 06 Apr 2020 20:07:54 -0700 From: Andrew Morton To: akpm@linux-foundation.org, hughd@google.com, linux-mm@kvack.org, mateusznosek0@gmail.com, mm-commits@vger.kernel.org, pankaj.gupta.linux@gmail.com, torvalds@linux-foundation.org, willy@infradead.org Subject: [patch 073/166] mm/shmem.c: clean code by removing unnecessary assignment Message-ID: <20200407030754.1PbjME_4J%akpm@linux-foundation.org> In-Reply-To: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek Subject: mm/shmem.c: clean code by removing unnecessary assignment Previously 0 was assigned to variable 'error' but the variable was never read before reassignemnt later. So the assignment can be removed. Link: http://lkml.kernel.org/r/20200301152832.24595-1-mateusznosek0@gmail.com Signed-off-by: Mateusz Nosek Reviewed-by: Matthew Wilcox (Oracle) Acked-by: Pankaj Gupta Cc: Hugh Dickins Signed-off-by: Andrew Morton --- mm/shmem.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/mm/shmem.c~mm-shmemc-clean-code-by-removing-unnecessary-assignment +++ a/mm/shmem.c @@ -3120,12 +3120,9 @@ static int shmem_symlink(struct inode *d error = security_inode_init_security(inode, dir, &dentry->d_name, shmem_initxattrs, NULL); - if (error) { - if (error != -EOPNOTSUPP) { - iput(inode); - return error; - } - error = 0; + if (error && error != -EOPNOTSUPP) { + iput(inode); + return error; } inode->i_size = len-1; _