From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34005C2BA16 for ; Tue, 7 Apr 2020 07:33:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 00053206F5 for ; Tue, 7 Apr 2020 07:33:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00053206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 940D38E0012; Tue, 7 Apr 2020 03:33:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F1B08E0001; Tue, 7 Apr 2020 03:33:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82E1D8E0012; Tue, 7 Apr 2020 03:33:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 686D48E0001 for ; Tue, 7 Apr 2020 03:33:53 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1F0F5942D for ; Tue, 7 Apr 2020 07:33:53 +0000 (UTC) X-FDA: 76680244746.16.gold28_793290fd4bf49 X-HE-Tag: gold28_793290fd4bf49 X-Filterd-Recvd-Size: 3333 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 07:33:52 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id h15so2623261wrx.9 for ; Tue, 07 Apr 2020 00:33:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lgXMyzs13NuYA6W3haexk1rgQVEgjk0KCFI11uwcdlc=; b=QxcvSoesXSaHfPjvnCfPLDW1S2dw8+2lkVpdSfNtVhXgILbIUuvwqCOSEYUUhbGxGB neuDdtatwhlrdqO20LMN6HLJS0FNXtz/PQfpGd9Tku0A+1wBK4lBCoY0NhASJ1Vkr6Qu N6zt90iTpZu7k1YOJpzcmSoERWRuFRCSnlIENoUziWFbL8tFlCS0bvIRkd3tQsNh7qWu 3SOLYykoRueOvWScPFZlBeicO0sI0pnNEoEmmlvvsM2W8nJdQRfms6Q0zevn+8aNoyqP zeDCqBqGlQ8jeIlYEP+Uy2A/W3hAc0bZi4eVkA8irEWJnxuNWsG32sOE3MLl2PwDSoDO 2iag== X-Gm-Message-State: AGi0PuYBzmNi1I25vLlgY28jqkrECVX22LjfZnIxDDQ16oq3g+iBoJC6 zGKzJ7o+GALo4InGHKk8ltI= X-Google-Smtp-Source: APiQypJ/3DH6y3lJq5QBhGCj/quYn/846Af14/JDIMx2bKATqWIcwSSk8+oHxllRL2DjGdyzy6iPkQ== X-Received: by 2002:adf:fa85:: with SMTP id h5mr1182699wrr.63.1586244831851; Tue, 07 Apr 2020 00:33:51 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id g186sm1184915wmg.36.2020.04.07.00.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2020 00:33:50 -0700 (PDT) Date: Tue, 7 Apr 2020 09:33:42 +0200 From: Michal Hocko To: NeilBrown Cc: Jan Kara , Christoph Hellwig , Trond Myklebust , "Anna.Schumaker@Netapp.com" , Andrew Morton , linux-mm@kvack.org, linux-nfs@vger.kernel.org, LKML Subject: Re: [PATCH 2/2 - v2] MM: Discard NR_UNSTABLE_NFS, use NR_WRITEBACK instead. Message-ID: <20200407071148.GE18914@dhcp22.suse.cz> References: <87tv2b7q72.fsf@notabene.neil.brown.name> <87v9miydai.fsf@notabene.neil.brown.name> <87sghmyd8v.fsf@notabene.neil.brown.name> <87pncqyd7k.fsf@notabene.neil.brown.name> <20200402151009.GA14130@infradead.org> <87h7y1y0ra.fsf@notabene.neil.brown.name> <20200403094220.GA29920@quack2.suse.cz> <87k12sw5ws.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k12sw5ws.fsf@notabene.neil.brown.name> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 07-04-20 09:28:19, Neil Brown wrote: > On Fri, Apr 03 2020, Jan Kara wrote: > > > > So I don't think we can just remove lines from procfs files like this. That > > has a high potential of breaking some userspace app that is not careful > > enough when parsing the file. So I think that we need to leave there the > > format string and just replace K(node_page_state(pgdat, NR_UNSTABLE_NFS)) > > with 0. > > OK. I assume changing the static trace points isn't a problem though? It shouldn't be until we learn that somebody depends on it... -- Michal Hocko SUSE Labs