From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5915FC2D0EA for ; Wed, 8 Apr 2020 12:24:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22DB1206F7 for ; Wed, 8 Apr 2020 12:24:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22DB1206F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BD0E68E0013; Wed, 8 Apr 2020 08:24:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B81318E000D; Wed, 8 Apr 2020 08:24:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A96F08E0013; Wed, 8 Apr 2020 08:24:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 94DC98E000D for ; Wed, 8 Apr 2020 08:24:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 514B1A8E1 for ; Wed, 8 Apr 2020 12:24:02 +0000 (UTC) X-FDA: 76684604724.05.ants68_5d66b63e73d47 X-HE-Tag: ants68_5d66b63e73d47 X-Filterd-Recvd-Size: 2155 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Apr 2020 12:24:01 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 450A868C4E; Wed, 8 Apr 2020 14:23:57 +0200 (CEST) Date: Wed, 8 Apr 2020 14:23:56 +0200 From: Christoph Hellwig To: Peter Zijlstra Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/28] mm: remove the prot argument from vm_map_ram Message-ID: <20200408122356.GA13282@lst.de> References: <20200408115926.1467567-1-hch@lst.de> <20200408115926.1467567-18-hch@lst.de> <20200408122104.GZ20713@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408122104.GZ20713@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 08, 2020 at 02:21:04PM +0200, Peter Zijlstra wrote: > On Wed, Apr 08, 2020 at 01:59:15PM +0200, Christoph Hellwig wrote: > > This is always GFP_KERNEL - for long term mappings with other properties > > vmap should be used. > > PAGE_KERNEL != GFP_KERNEL :-) Yep. The compiler complained about that a few times :)