From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C83C2D0EA for ; Wed, 8 Apr 2020 15:40:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A48452072F for ; Wed, 8 Apr 2020 15:40:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A48452072F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 484F88E000D; Wed, 8 Apr 2020 11:40:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4356B8E0006; Wed, 8 Apr 2020 11:40:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 372648E000D; Wed, 8 Apr 2020 11:40:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 1EFB48E0006 for ; Wed, 8 Apr 2020 11:40:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D002E8248D51 for ; Wed, 8 Apr 2020 15:40:37 +0000 (UTC) X-FDA: 76685100114.10.knot70_3faabe5c84853 X-HE-Tag: knot70_3faabe5c84853 X-Filterd-Recvd-Size: 1722 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Apr 2020 15:40:37 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 0BEE968C65; Wed, 8 Apr 2020 17:40:34 +0200 (CEST) Date: Wed, 8 Apr 2020 17:40:33 +0200 From: Christoph Hellwig To: Hillf Danton Cc: Christoph Hellwig , Andrew Morton , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, syzkaller-bugs@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/28] staging: android: ion: use vmap instead of vm_map_ram Message-ID: <20200408154033.GA28499@lst.de> References: <20200408115926.1467567-1-hch@lst.de> <20200408124833.13032-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408124833.13032-1-hdanton@sina.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 08, 2020 at 08:48:33PM +0800, Hillf Danton wrote: > > - void *addr = vm_map_ram(pages, num, -1, pgprot); > > + void *addr = vmap(pages, num, VM_MAP); > > A merge glitch? > > void *vmap(struct page **pages, unsigned int count, > unsigned long flags, pgprot_t prot) Yes, thanks for the headsup, you were as fast as the build bot :) Fixed now.