linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Zi Yan <ziy@nvidia.com>
Cc: akpm@linux-foundation.org, Andrea Arcangeli <aarcange@redhat.com>,
	Yang Shi <yang.shi@linux.alibaba.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCHv2 1/8] khugepaged: Add self test
Date: Fri, 10 Apr 2020 14:47:39 +0300	[thread overview]
Message-ID: <20200410114739.b2ndracbyhsdmanv@box> (raw)
In-Reply-To: <D55D6A3A-47A1-41F5-B939-36EEA740CF72@nvidia.com>

On Mon, Apr 06, 2020 at 10:59:52AM -0400, Zi Yan wrote:
> I ran this test with all patches from this series applied to Linus’s tree, but still see several failures. Is it expected?
> The config file is attached. Let me know if I miss anything. BTW, I am running in a VM.
> 
> Thanks.
> 
> The output:
> 
> ➜  ~ sudo ./khugepaged
> Save THP and khugepaged settings... OK
> Adjust settings... OK
> Allocate huge page on fault... OK
> Split huge PMD on MADV_DONTNEED... OK
> Collapse fully populated PTE table.... Fail

I was able to reproduce the issue. And it's fun failure mode.

How did you get the test case inside the VM? Copy-paste source using 'cat'
or something similar inside the VM?

It screwed up CHECK_HUGE_FMT and CHECK_SWAP_FMT for me. Double back slash
was converted to single. As result check_huge() and check_swap() gave the
false-negative result all the time.

Could you check that the source of the test-case is not mangled and
re-test if it is.

-- 
 Kirill A. Shutemov


  parent reply	other threads:[~2020-04-10 11:47 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03 11:29 [PATCHv2 0/8] thp/khugepaged improvements and CoW semantics Kirill A. Shutemov
2020-04-03 11:29 ` [PATCHv2 1/8] khugepaged: Add self test Kirill A. Shutemov
2020-04-06 14:59   ` Zi Yan
2020-04-06 15:20     ` Kirill A. Shutemov
2020-04-06 18:50       ` Zi Yan
2020-04-08 14:21         ` Kirill A. Shutemov
2020-04-08 15:53           ` Zi Yan
2020-04-10 11:47     ` Kirill A. Shutemov [this message]
2020-04-10 14:36       ` Zi Yan
2020-04-10 14:58         ` Kirill A. Shutemov
2020-04-10 15:03           ` Zi Yan
2020-04-06 18:53   ` Ralph Campbell
2020-04-03 11:29 ` [PATCHv2 2/8] khugepaged: Do not stop collapse if less than half PTEs are referenced Kirill A. Shutemov
2020-04-06 18:13   ` Yang Shi
2020-04-06 19:53   ` Ralph Campbell
2020-04-09 13:34     ` Kirill A. Shutemov
2020-04-03 11:29 ` [PATCHv2 3/8] khugepaged: Drain all LRU caches before scanning pages Kirill A. Shutemov
2020-04-06 18:15   ` Yang Shi
2020-04-03 11:29 ` [PATCHv2 4/8] khugepaged: Drain LRU add pagevec after swapin Kirill A. Shutemov
2020-04-06 13:11   ` Zi Yan
2020-04-06 18:29   ` Yang Shi
2020-04-08 13:05     ` Kirill A. Shutemov
2020-04-08 18:42       ` Yang Shi
2020-04-03 11:29 ` [PATCHv2 5/8] khugepaged: Allow to callapse a page shared across fork Kirill A. Shutemov
2020-04-06 20:15   ` Ralph Campbell
2020-04-06 20:50   ` Yang Shi
2020-04-08 13:10     ` Kirill A. Shutemov
2020-04-08 18:51       ` Yang Shi
2020-04-10  0:03         ` Yang Shi
2020-04-10 15:56           ` Kirill A. Shutemov
2020-04-06 21:30   ` John Hubbard
2020-04-10 15:55     ` Kirill A. Shutemov
2020-04-10 20:59       ` John Hubbard
2020-04-13  9:42         ` Kirill A. Shutemov
2020-04-03 11:29 ` [PATCHv2 6/8] khugepaged: Allow to collapse PTE-mapped compound pages Kirill A. Shutemov
2020-04-06 21:29   ` Yang Shi
2020-04-08 13:29     ` Kirill A. Shutemov
2020-04-08 18:57       ` Yang Shi
2020-04-09 13:47         ` Kirill A. Shutemov
2020-04-03 11:29 ` [PATCHv2 7/8] thp: Change CoW semantics for anon-THP Kirill A. Shutemov
2020-04-07  7:57   ` [thp] db001b7115: vm-scalability.median 8.9% improvement kernel test robot
2020-04-03 11:29 ` [PATCHv2 8/8] khugepaged: Introduce 'max_ptes_shared' tunable Kirill A. Shutemov
2020-04-06 13:17   ` Zi Yan
2020-04-05 23:40 ` [PATCHv2 0/8] thp/khugepaged improvements and CoW semantics William Kucharski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200410114739.b2ndracbyhsdmanv@box \
    --to=kirill@shutemov.name \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yang.shi@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).