From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CB2C2D0EC for ; Fri, 10 Apr 2020 19:27:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B63220732 for ; Fri, 10 Apr 2020 19:27:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GcfgONn4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B63220732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D52A8E0057; Fri, 10 Apr 2020 15:27:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 184C98E004D; Fri, 10 Apr 2020 15:27:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04DE58E0057; Fri, 10 Apr 2020 15:27:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id DE25D8E004D for ; Fri, 10 Apr 2020 15:27:03 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9A3D9181AEF0B for ; Fri, 10 Apr 2020 19:27:03 +0000 (UTC) X-FDA: 76692928326.10.wave03_77ccdfa8f3c12 X-HE-Tag: wave03_77ccdfa8f3c12 X-Filterd-Recvd-Size: 5416 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Apr 2020 19:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586546822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=egTRqYjBdzetC6Rav2slWK+++8cSaJtQCNbovjaGoc8=; b=GcfgONn4XaHWe5LZKohORDPRkoly8L0FK9eLsVPvVPvXOwI961gPynIlhjo7dV5hfVE5qV yZcoN/6b09F22GU5Ttbby0oh6U2jAlvqzUbCpZAMKpIrInsidH1achRW0bTEvoIVeMo5go 1EjvCmgF0/Ga6xmL/EUpmc6HYi5gCFI= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-z-u8-cUoMxW_RA0hlRlrZA-1; Fri, 10 Apr 2020 15:27:00 -0400 X-MC-Unique: z-u8-cUoMxW_RA0hlRlrZA-1 Received: by mail-qt1-f199.google.com with SMTP id a3so2700242qtm.5 for ; Fri, 10 Apr 2020 12:27:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ddNmEkCT3NuYAPr19Gh+8RyFM7t2I+OUmUTTKHVjsXQ=; b=flaTGTybgiEMq63vc/LcqNtWOfWRnPJOOsjohWsB1i1ho200RqibMwnEp7qc5NyF7d YHYkSSRHrrQx94Xsxq99dUCZrgisxjWm4J+P2O1GtNvxQMxV0sFFqHLfoNR4KqF3nJIi Ys5QteLMMZviMve4HbWBPHaOIfAPYxRl5LYALK3JHSdL9Y4DzanLUTfTLYwAUl4ZSWJ2 m04mG0WahXQBe10YSLntGt9UukO324np0BaE7nnsnjcfR8EhSzKuYnC6PdYDHRZ7bFrv 5B3m3Z+WkL5+fk3Mp9VQfWq9T+Gu3+FTyrtCU8OAGgjGPA3YcODD14VeGXk+ihgkNsjt uMnA== X-Gm-Message-State: AGi0PuYtgKxXEMYJYw4VNn5iHxb0QNy6z/yn2xH8nw1YlM5s8YRanW3T TnNjtpG/z8JjIanD2QqjE6BwDFh90MpLCpSlTgMEAHDWJpdSn4wFUHOxpYCk1CnFkzzhj0KQVEp aQWe/rwnuq90= X-Received: by 2002:ac8:2c66:: with SMTP id e35mr769608qta.188.1586546820323; Fri, 10 Apr 2020 12:27:00 -0700 (PDT) X-Google-Smtp-Source: APiQypJUBND9mw4a79BsRjlZQBzcyo9K+K4n4uLp4F1mRayVM5WnYx0Zu2cY7436wozu46yjuIupKQ== X-Received: by 2002:ac8:2c66:: with SMTP id e35mr769568qta.188.1586546820098; Fri, 10 Apr 2020 12:27:00 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id o33sm2321940qtj.62.2020.04.10.12.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:26:59 -0700 (PDT) Date: Fri, 10 Apr 2020 15:26:56 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Mina Almasry , Andrew Morton Subject: Re: [PATCH v2 2/4] hugetlbfs: move hugepagesz= parsing to arch independent code Message-ID: <20200410192656.GE3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-3-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20200401183819.20647-3-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 01, 2020 at 11:38:17AM -0700, Mike Kravetz wrote: > Now that architectures provide arch_hugetlb_valid_size(), parsing > of "hugepagesz=3D" can be done in architecture independent code. > Create a single routine to handle hugepagesz=3D parsing and remove > all arch specific routines. We can also remove the interface > hugetlb_bad_size() as this is no longer used outside arch independent > code. >=20 > This also provides consistent behavior of hugetlbfs command line > options. The hugepagesz=3D option should only be specified once for > a specific size, but some architectures allow multiple instances. > This appears to be more of an oversight when code was added by some > architectures to set up ALL huge pages sizes. >=20 > Signed-off-by: Mike Kravetz This could change the error messages for a wrong setup on archs, but I guess it's not a big deal, assuming even to capture error people will majorly still look for error lines in general.. Reviewed-by: Peter Xu --=20 Peter Xu