From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB0BC2BB55 for ; Fri, 10 Apr 2020 19:34:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0712A206C1 for ; Fri, 10 Apr 2020 19:34:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HTjtrTCP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0712A206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF8318E0059; Fri, 10 Apr 2020 15:34:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA81D8E004D; Fri, 10 Apr 2020 15:34:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 997A18E0059; Fri, 10 Apr 2020 15:34:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 7ED108E004D for ; Fri, 10 Apr 2020 15:34:26 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3D06F181AEF1F for ; Fri, 10 Apr 2020 19:34:26 +0000 (UTC) X-FDA: 76692946932.06.drug13_26b38be46ec33 X-HE-Tag: drug13_26b38be46ec33 X-Filterd-Recvd-Size: 4829 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Apr 2020 19:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586547265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pSDLH5WsDUY0Ls+Yi5DMpK6wFwspuCJoAo5jQ7V/Ijc=; b=HTjtrTCPCtqlucaZeYXO9hdRWKKNAckT7ekZDJXF4mJhpipaNA9I2CNaZ2kSj9hZ8JMDfd x8O+SqhSx6dStv8V30+AeWP2e15nVJrSHFhqsats/yWfEKX2i5V8jL8upV5bG1UT+dmM/5 7kohKTXNMLmKBR1LDF3Ev3cAOymTgN8= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-Xmlc0J-XMfSqvaC7a-x_DQ-1; Fri, 10 Apr 2020 15:34:23 -0400 X-MC-Unique: Xmlc0J-XMfSqvaC7a-x_DQ-1 Received: by mail-qk1-f200.google.com with SMTP id e11so2911941qka.12 for ; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=QH6m9xT2pA7VM6iKh2zPICjs2zJfYCGizl4PGD+GDbEDDl98tLYo9b9C7OKVzDY4kA Z0ERY88jxaBSPy849SROyRpxxhwVHIQi++jzYsDK4bojFbxDA514OZrO1MpKNyeJtbtf KK2DimwfnJAZphCsY4HsqLdLElt5FPLZSQWoHvjd9ahBVlZJmlYeue+qHBjDn9a+Faqu smE9s8MtCHZ52xr+WxyEqL3Yg/5QMsz0qsVnUjke5mLWK3youBAT0afgVfozXlA0ku5P GW4w7PPml/3VPSWZSPcmEnbOuPp01SI8Un4SSgdkHJEM6MO5nrWLUtPBfPYD0gWJMsUl 2siw== X-Gm-Message-State: AGi0PuZmT9MJtnh768P43ldikXBl+ElLTlACI7WoGSW6jg/MWI9a8lsf LEFERlX0p0x51p1VywsjI9BWuozQNdQrRWna2YgGQXoCT7HdJsGWeVH0MzDF0NBaeAbClPMMEK5 HOs1MuZFZoP4= X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768746qtt.165.1586547263230; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-Smtp-Source: APiQypKE+9gdKAAzqM7E075abKl7yEhzpSisddiPAFgdbjLHprLwAVDEdymEnBo0qMB8GT4NFqVJjg== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768725qtt.165.1586547263017; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id m11sm2214328qkg.130.2020.04.10.12.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:34:22 -0700 (PDT) Date: Fri, 10 Apr 2020 15:34:19 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Mina Almasry , Andrew Morton Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-ID: <20200410193419.GF3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > =09unsigned long i; > =20 > =09if (size_to_hstate(PAGE_SIZE << order)) { > -=09=09pr_warn("hugepagesz=3D specified twice, ignoring\n"); > =09=09return; > =09} Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu --=20 Peter Xu