From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEC7C2BB55 for ; Mon, 13 Apr 2020 02:37:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60AD5206DA for ; Mon, 13 Apr 2020 02:37:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cTHa2/vb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60AD5206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D321A8E00F5; Sun, 12 Apr 2020 22:37:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE32D8E00D0; Sun, 12 Apr 2020 22:37:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8478E00F5; Sun, 12 Apr 2020 22:37:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id A8E008E00D0 for ; Sun, 12 Apr 2020 22:37:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 618BC824556B for ; Mon, 13 Apr 2020 02:37:12 +0000 (UTC) X-FDA: 76701269904.10.sock43_3eddd245d0a26 X-HE-Tag: sock43_3eddd245d0a26 X-Filterd-Recvd-Size: 6384 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Apr 2020 02:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586745431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cNWdc1cSaVS1ulqLAzfjy25i8fkF6PupRqxs9vt81WU=; b=cTHa2/vbmPjGxCTcb1/ZmWYQpXlqL0tcm/qWjU7S3oRcKGnsn+K6gPmyXrqmvxlWW8hE54 gtCXyx605jVQOMM7j3h5SqRD+D6kUA4Hg3nCDOQKPeaHpA9S9lQjDl0hn2mrHMHcj++xyu dQTbbSqqYGgkFEuQM5m1RM7S2b1/Wr0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-279-AC8HmX-qO2OON4JV2G2ccA-1; Sun, 12 Apr 2020 22:37:09 -0400 X-MC-Unique: AC8HmX-qO2OON4JV2G2ccA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0887D18B5FA1; Mon, 13 Apr 2020 02:37:08 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF2B911D2C4; Mon, 13 Apr 2020 02:37:03 +0000 (UTC) Date: Mon, 13 Apr 2020 10:37:01 +0800 From: Baoquan He To: "Eric W. Biederman" Cc: Russell King - ARM Linux admin , Anshuman Khandual , Catalin Marinas , Bhupesh Sharma , David Hildenbrand , kexec@lists.infradead.org, linux-mm@kvack.org, James Morse , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] kexec: Prevent removal of memory in use by a loaded kexec image Message-ID: <20200413023701.GA20265@MiWiFi-R3L-srv> References: <34274b02-60ba-eb78-eacd-6dc1146ed3cd@arm.com> <80e4d1d7-f493-3f66-f700-86f18002d692@redhat.com> <20200410121013.03b609fd572504c03a666f4a@linux-foundation.org> <20200411034414.GH2129@MiWiFi-R3L-srv> <20200411093009.GH25745@shell.armlinux.org.uk> <20200412053507.GA4247@MiWiFi-R3L-srv> <20200412080836.GM25745@shell.armlinux.org.uk> <87wo6klbw0.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 In-Reply-To: <87wo6klbw0.fsf@x220.int.ebiederm.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04/12/20 at 02:52pm, Eric W. Biederman wrote: >=20 > The only benefit of kexec_file_load is that it is simple enough from a > kernel perspective that signatures can be checked. We don't have this restriction any more with below commit: commit 99d5cadfde2b ("kexec_file: split KEXEC_VERIFY_SIG into KEXEC_SIG and KEXEC_SIG_FORCE") With KEXEC_SIG_FORCE not set, we can use kexec_load_file to cover both secure boot or legacy system for kexec/kdump. Being simple enough is enough to astract and convince us to use it instead. And kexec_file_load has been in use for several years on systems with secure boot, since added in 2014, on x86_64. >=20 > kexec_load in every other respect is the more capable and functional > interface. It makes no sense to get rid of it. >=20 > It does make sense to reload with a loaded kernel on memory hotplug. > That is simple and easy. If we are going to handle something in the > kernel it should simple an automated unloading of the kernel on memory > hotplug. >=20 >=20 > I think it would be irresponsible to deprecate kexec_load on any > platform. >=20 > I also suspect that kexec_file_load could be taught to copy the dtb > on arm32 if someone wants to deal with signatures. >=20 > We definitely can not even think of deprecating kexec_load until > architecture that supports it also supports kexec_file_load and everyone > is happy with that interface. That is Linus's no regression rule. I should pick a milder word to express our tendency and tell our plan then 'obsolete'. Even though I added 'gradually', seems it doesn't help much. I didn't mean to say 'deprecate' at all when replied. The situation and trend I understand about kexec_load and kexec_file_load are: 1) Supporting kexec_file_load is suggested to add in ARCHes which don't have yet, just as x86_64, arm64 and s390 have done; =20 2) kexec_file_load is suggested to use, and take precedence over kexec_load in the future, if both are supported in one ARCH. 3) Kexec_load is kept being used by ARCHes w/o kexc_file_load support, and by ARCHes for back compatibility w/ kexec_file_load support. For 1) and 2), I think the reason is obvious as Eric said, kexec_file_load is simple enough. And currently, whenever we got a bug report, we may need fix them twice, for kexec_load and kexec_file_load. If kexec_file_load is made by default, e.g on x86_64, we will change it in kernel space only, for kexec_file_load. This is what I meant about 'obsolete gradually'. I think for arm64, s390, they will do these too. Unless there's some critical/blocker bug in kexec_load, to corrupt the old kexec_load interface in old product. For 3), people can still use kexec_load and develop/fix for it, if no kexec_file_load supported. But 32-bit arm should be a different one, more like i386, we will leave it as is, and fix anything which could break it. But people really expects to improve or add feature to it? E.g in this patchset, the mem hotplug issue James raised, I assume James is focusing on arm64, x86_64, but not 32-bit arm. As DavidH commented in another reply, people even don't agree to continue supporting memory hotplug on 32-bit system. We ever took effort to fix a memory hotplug bug on i386 with a patch, but people would rather set it as BROKEN.