From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9838C2BA19 for ; Mon, 13 Apr 2020 13:31:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D5C02073E for ; Mon, 13 Apr 2020 13:31:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D5C02073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A32C8E0117; Mon, 13 Apr 2020 09:31:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 353938E0104; Mon, 13 Apr 2020 09:31:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 268A58E0117; Mon, 13 Apr 2020 09:31:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 0DC4D8E0104 for ; Mon, 13 Apr 2020 09:31:55 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BD0A4180AD802 for ; Mon, 13 Apr 2020 13:31:54 +0000 (UTC) X-FDA: 76702919748.21.nest01_67f4b056e631b X-HE-Tag: nest01_67f4b056e631b X-Filterd-Recvd-Size: 4465 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Apr 2020 13:31:54 +0000 (UTC) Received: from mail-wm1-f71.google.com ([209.85.128.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jNzBo-0003ih-SQ for linux-mm@kvack.org; Mon, 13 Apr 2020 13:31:53 +0000 Received: by mail-wm1-f71.google.com with SMTP id o5so2655818wmo.6 for ; Mon, 13 Apr 2020 06:31:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QaapbS3AwpMQJO1PlO7vQLfoDd/t8Pv7NCHZnFtR9R8=; b=OmRtL8zgY4W8BdCVRYIf0hU6CvkH/r3FAFD7QJICKjZstJ7YtTYedVgyKrBiCwo+kF WvICZ5lW/3m2y0Wg2wU2IcZpG+qv3UB3up+0vk+MFJtqUv+8vatKozWWWSSyuLQWcHF/ rWGDVJDoMaIs6pmfvJstBSOr/kwban1lmc016wyUAb2zkW/lBQ+IHoIrsyOz4AqVOMAW 2sFSSfKV9OLs4TlZXwoCdgB7u4gicyc0A2H2QkysXs5S+BhfigyAmAQl/dUj9nCCmV2j OWdumKIUq9/QdFTuRkvQfCZYmjPrlVfCsg1hByHOpHGXzKF7I4zznY7coLllnoWVBSdx CVPQ== X-Gm-Message-State: AGi0PuZrEc79c820tK+obZQHmuTd9wLwwWet1T+mpxnJmgtgWGru14YH dbagXteGZIm0F5IWAoEa1MOBosN6QO/xZVaWNueLrqe7/Np4QT7TyMCQ3TQABV52N00Dy4Tqo1j ZJwFGdfTGOQpYdJ4+j2DIQLjAkxpI X-Received: by 2002:a7b:c247:: with SMTP id b7mr18717045wmj.35.1586784712516; Mon, 13 Apr 2020 06:31:52 -0700 (PDT) X-Google-Smtp-Source: APiQypJbHqcshOES1POOpbSkrd5awhLm8EajB366CYNGu2GARJYA8cZtN4ZuoZfz+7mcb6QHwtl+7A== X-Received: by 2002:a7b:c247:: with SMTP id b7mr18717027wmj.35.1586784712276; Mon, 13 Apr 2020 06:31:52 -0700 (PDT) Received: from localhost (host123-127-dynamic.36-79-r.retail.telecomitalia.it. [79.36.127.123]) by smtp.gmail.com with ESMTPSA id h17sm3289803wmm.6.2020.04.13.06.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2020 06:31:51 -0700 (PDT) Date: Mon, 13 Apr 2020 15:31:50 +0200 From: Andrea Righi To: "Huang, Ying" Cc: Andrew Morton , Minchan Kim , Anchal Agarwal , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: swap: use fixed-size readahead during swapoff Message-ID: <20200413133150.GA810380@xps-13> References: <20200413111810.GA801367@xps-13> <87a73f7d71.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a73f7d71.fsf@yhuang-dev.intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 13, 2020 at 09:00:34PM +0800, Huang, Ying wrote: > Andrea Righi writes: > > [snip] > > > diff --git a/mm/swap_state.c b/mm/swap_state.c > > index ebed37bbf7a3..c71abc8df304 100644 > > --- a/mm/swap_state.c > > +++ b/mm/swap_state.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > #include > > > > #include > > @@ -507,6 +508,14 @@ static unsigned long swapin_nr_pages(unsigned long offset) > > max_pages = 1 << READ_ONCE(page_cluster); > > if (max_pages <= 1) > > return 1; > > + /* > > + * If current task is using too much memory or swapoff is running > > + * simply use the max readahead size. Since we likely want to load a > > + * lot of pages back into memory, using a fixed-size max readhaead can > > + * give better performance in this case. > > + */ > > + if (oom_task_origin(current)) > > + return max_pages; > > > > hits = atomic_xchg(&swapin_readahead_hits, 0); > > pages = __swapin_nr_pages(prev_offset, offset, hits, max_pages, > > Thinks this again. If my understanding were correct, the accessing > pattern during swapoff is sequential, why swap readahead doesn't work? > If so, can you root cause that firstly? Theoretically if the pattern is sequential the current heuristic should already select a big readahead size, but apparently it's not doing that. I'll repeat my tests tracing the readahead size during swapoff to see exactly what's going on here. Thanks, -Andrea