From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42636C2BB1D for ; Wed, 15 Apr 2020 01:17:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04ADB2076C for ; Wed, 15 Apr 2020 01:17:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="trHGKNCx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04ADB2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 87F108E0003; Tue, 14 Apr 2020 21:17:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82F258E0001; Tue, 14 Apr 2020 21:17:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71DB28E0003; Tue, 14 Apr 2020 21:17:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 574A18E0001 for ; Tue, 14 Apr 2020 21:17:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 187DB8245571 for ; Wed, 15 Apr 2020 01:17:08 +0000 (UTC) X-FDA: 76708325736.25.train82_3e3efc0d31505 X-HE-Tag: train82_3e3efc0d31505 X-Filterd-Recvd-Size: 2838 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 01:17:07 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CD58206D9; Wed, 15 Apr 2020 01:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586913426; bh=Z8t12Kri4dLkYoQfBj9LeTBHSVbJC29k8QLFe4WYAn0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=trHGKNCxzakSMiiFFW7h7ipr5l5ZPqXMRMACUtk4YKpwd8Pg1RJ2PiBsRP5nCE9+1 fCvzyZDvGOZsZH+JWcOhF2bmZOk4UdQ9IgBloKo9E4jlYJXAc0OSn746DXLsWt7WBJ s1ct6x0rSpHRCfj/HRWtfY1TDdkeieGLLTsLzoWE= Date: Tue, 14 Apr 2020 18:17:05 -0700 From: Andrew Morton To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org, Christoph Hellwig , William Kucharski Subject: Re: [PATCH v11 05/25] mm: Add new readahead_control API Message-Id: <20200414181705.bfc4c0087092051a9475141e@linux-foundation.org> In-Reply-To: <20200414150233.24495-6-willy@infradead.org> References: <20200414150233.24495-1-willy@infradead.org> <20200414150233.24495-6-willy@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Apr 2020 08:02:13 -0700 Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Filesystems which implement the upcoming ->readahead method will get > their pages by calling readahead_page() or readahead_page_batch(). > These functions support large pages, even though none of the filesystems > to be converted do yet. > > +static inline struct page *readahead_page(struct readahead_control *rac) > +static inline unsigned int __readahead_batch(struct readahead_control *rac, > + struct page **array, unsigned int array_sz) These are large functions. Was it correct to inline them? The batching API only appears to be used by fuse? If so, do we really need it? Does it provide some functional need, or is it a performance thing? If the latter, how significant is it? The code adds quite a few (inlined!) VM_BUG_ONs. Can we plan to remove them at some stage? Such as, before Linus shouts at us :)