From: Michal Hocko <mhocko@kernel.org>
To: Leonid Moiseichuk <lmoiseichuk@magicleap.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
svc lmoiseichuk <svc_lmoiseichuk@magicleap.com>,
vdavydov.dev@gmail.com, tj@kernel.org, lizefan@huawei.com,
cgroups@vger.kernel.org, akpm@linux-foundation.org,
rientjes@google.com, minchan@kernel.org, vinmenon@codeaurora.org,
andriy.shevchenko@linux.intel.com, penberg@kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 0/2] memcg, vmpressure: expose vmpressure controls
Date: Wed, 15 Apr 2020 09:55:32 +0200 [thread overview]
Message-ID: <20200415075532.GZ4629@dhcp22.suse.cz> (raw)
In-Reply-To: <CAELvCDS_z-bTvRZ7fxkfHjnjV1WzFcxarzrbT1pDwkXX_dmOoA@mail.gmail.com>
On Tue 14-04-20 18:12:47, Leonid Moiseichuk wrote:
> I do not agree with all comments, see below.
>
> On Tue, Apr 14, 2020 at 3:23 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> > On Tue, Apr 14, 2020 at 12:42:44PM -0400, Leonid Moiseichuk wrote:
> > > On Tue, Apr 14, 2020 at 7:37 AM Michal Hocko <mhocko@kernel.org> wrote:
> > > > On Mon 13-04-20 17:57:48, svc_lmoiseichuk@magicleap.com wrote:
> > > > Anyway, I have to confess I am not a big fan of this. vmpressure turned
> > > > out to be a very weak interface to measure the memory pressure. Not
> > only
> > > > it is not numa aware which makes it unusable on many systems it also
> > > > gives data way too late from the practice.
> >
> > Yes, it's late in the game for vmpressure, and also a bit too late for
> > extensive changes in cgroup1.
> >
> 200 lines just to move functionality from one place to another without
> logic change?
> There does not seem to be extensive changes.
Any user visible API is an big change. We have to maintain any api for
ever. So there has to be a really strong reason/use case for inclusion.
I haven't heard any strong justification so far. It all seems to me that
you are trying to workaround real vmpressure issues by fine tunning
parameters and that is almost always a bad reason for a adding a new
tunning.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2020-04-15 7:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:57 [PATCH 0/2] memcg, vmpressure: expose vmpressure controls svc_lmoiseichuk
2020-04-13 21:57 ` [PATCH 1/2] memcg: expose vmpressure knobs svc_lmoiseichuk
2020-04-14 22:55 ` Chris Down
2020-04-14 23:00 ` Leonid Moiseichuk
2020-04-13 21:57 ` [PATCH 2/2] memcg, vmpressure: expose vmpressure controls svc_lmoiseichuk
2020-04-14 11:37 ` [PATCH 0/2] " Michal Hocko
2020-04-14 16:42 ` Leonid Moiseichuk
2020-04-14 18:49 ` Michal Hocko
2020-04-14 20:53 ` Leonid Moiseichuk
2020-04-15 7:51 ` Michal Hocko
2020-04-15 12:17 ` Leonid Moiseichuk
2020-04-15 12:28 ` Michal Hocko
2020-04-15 12:33 ` Leonid Moiseichuk
2020-04-14 19:23 ` Johannes Weiner
2020-04-14 22:12 ` Leonid Moiseichuk
2020-04-15 7:55 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415075532.GZ4629@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=lmoiseichuk@magicleap.com \
--cc=minchan@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=svc_lmoiseichuk@magicleap.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).