From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE53FC2BA19 for ; Wed, 15 Apr 2020 10:16:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 895A8214AF for ; Wed, 15 Apr 2020 10:16:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 895A8214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 230008E0003; Wed, 15 Apr 2020 06:16:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E0F38E0001; Wed, 15 Apr 2020 06:16:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F73F8E0003; Wed, 15 Apr 2020 06:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id E92F68E0001 for ; Wed, 15 Apr 2020 06:16:22 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9CB4E8245571 for ; Wed, 15 Apr 2020 10:16:22 +0000 (UTC) X-FDA: 76709684604.27.frogs65_71d84a437e70d X-HE-Tag: frogs65_71d84a437e70d X-Filterd-Recvd-Size: 4410 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 10:16:22 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id d77so16730861wmd.3 for ; Wed, 15 Apr 2020 03:16:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6RF4WufMmMDOeU7tEnVUbEzApfb4RzYUUgBLy7xNXoc=; b=VoqO/CDcccMrX0pbfKlHV8TxhuRl5AlEjYtcTfJQMe6RxIADujf7Wsj2jD/JQaFabJ LbIhCg5xq7/ikvQlDeRKo8JIAiygdDHeiFbU9LslLwQVLZheydmPGU9q41KqUvTqYCQr ysiEfLjssGHZ5fQyj/65wtuHryd3XpOtLtn5c1zecu+QWVMw5acMeoL+lqmsp7pH0dR+ R+t+UEZL9sMPxFhZApM+DPXyChLnVU+6q/n2ELqqeNckD9Sf35+EUFKZPlYLzAIemuUt FriVFJgxsKHMxRK4QOgPXeWv0YugN2ub75yc2GqtHlNgqbEJcNatquoOAqpXW88+VdY3 L0bg== X-Gm-Message-State: AGi0PuY+E/Hbu+BAs+RhKvh2MafBG0Qr7qcZU7B/dugDn/uph5d/g3/e HzlXUwDoaFphNWYwVCB+rqw= X-Google-Smtp-Source: APiQypKwwZOSZo6TKJ0VX0uh/VRxb42E0lr4O+D1OO7/WfRpILKWx7YwVM17KF5oioj4FCitYR+BbA== X-Received: by 2002:a1c:5ac4:: with SMTP id o187mr4704758wmb.79.1586945781247; Wed, 15 Apr 2020 03:16:21 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id h137sm17223451wme.0.2020.04.15.03.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 03:16:20 -0700 (PDT) Date: Wed, 15 Apr 2020 12:16:18 +0200 From: Michal Hocko To: David Hildenbrand Cc: Anshuman Khandual , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, catalin.marinas@arm.com, mark.rutland@arm.com, Dan Williams , Yu Zhao , Hsin-Yi Wang , Thomas Gleixner , Steve Capper , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] arm64/hotplug: Process MEM_OFFLINE and MEM_CANCEL_OFFLINE events Message-ID: <20200415101618.GD4629@dhcp22.suse.cz> References: <1586932784-16315-1-git-send-email-anshuman.khandual@arm.com> <31ce355b-abf7-ac3b-a5b4-ae1b0a52fb3c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31ce355b-abf7-ac3b-a5b4-ae1b0a52fb3c@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 15-04-20 09:35:33, David Hildenbrand wrote: > On 15.04.20 08:39, Anshuman Khandual wrote: > > This series improves arm64 memory event notifier (hot remove) robustness by > > enabling it to detect potential problems (if any) in the future. But first > > it enumerates memory isolation failure reasons that can be sent across a > > notifier. This series does not go beyond arm64 to explore if these failure > > reason codes could be used in other existing registered memory notifiers. > > Please do let me know if there is any other potential use cases, will be > > happy to incorporate next time around. Also should we add similar failure > > reasons for online_pages() as well ? > > > > This series has been tested on arm64, boot tested on x86 and build tested > > on multiple other platforms. > > > > I'm sorry, but I have to nack this series. Why? > > 1. A hotplug notifier should not have to bother why offlining failed. He > received a MEM_GOING_OFFLINE, followed by a MEM_CANCEL_OFFLINE. That's > all he really has to know. Undo what you've done, end of story. > > 2. Patch 2 just introduces dead code that should never happen unless > something is horribly broken in the core (memory offlined although > nacked from notifier). And, it (for *whatever reason*) thinks it's okay > to bail out if another noYtifier canceled offlining hotplugged memory. > > I fail to see the benefit for core changes and Agreed! If arm64 wants to check and report early bootmem memory offlining then just do it. There is no reason to add a whole machinery for that. Cancel notifier is indeed only supposed to restore the state before GOING_OFFLINE. > 4 files changed, 99 insertions(+), 13 deletions(-) -- Michal Hocko SUSE Labs