From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B06AC2BB55 for ; Wed, 15 Apr 2020 10:43:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4704120737 for ; Wed, 15 Apr 2020 10:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4704120737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C557E8E0008; Wed, 15 Apr 2020 06:43:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C05DD8E0001; Wed, 15 Apr 2020 06:43:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1A3B8E0008; Wed, 15 Apr 2020 06:43:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 96D058E0001 for ; Wed, 15 Apr 2020 06:43:42 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5651B52BF for ; Wed, 15 Apr 2020 10:43:42 +0000 (UTC) X-FDA: 76709753484.16.sack26_3d6ca0b8f2614 X-HE-Tag: sack26_3d6ca0b8f2614 X-Filterd-Recvd-Size: 3018 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 10:43:41 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id d27so9327527wra.1 for ; Wed, 15 Apr 2020 03:43:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U4/j6DsdU58IfdYBzmmkMpF8PTjT5JEuky8VhAe+f5Q=; b=XYFKEjNx0yGmLeL1G1zKl8VEUq6Ib9AKk0FZQ8rNHVSVZfv4QO3HbhkngktdaeExr3 u/6Efmwwl3umxOh7qZ6fjwp04Vnlfq/MZnQheHdBLVJy49fcEcATZnsePROGMFqd9hT+ 8b+lec8mPBDWU2DssTJQrXWEJkn6QWCLAtscuE+CyEVuP4on+bSMqysCN65D4pVfcsnD jal8I22GhqNL4g0xiIGcuOvvAW3eEWQT6A+2OaOp5SUWDVdnmXf6+j8Wd90G8C2XUajp aO8NyZsw5enG/zv6vP/G+bQL7MimJ/78TzNcUg8kcMSkAvmILjI+FUbesr31Hn6FsqlZ ziEA== X-Gm-Message-State: AGi0PuYQUnsJgshNuPUJFNulm5o1GgKX+sNu+J2nQKb2JFe96dihOzNh Qy2WnQFyLmSOrY0SvpB4V9U= X-Google-Smtp-Source: APiQypLORd/IKgRFpp7S3dA/ZU6/sxCxycvBJkbVFL1bUdvL8hM/nU4Hz7cjmSOUwFyYBpEH5FNTqg== X-Received: by 2002:adf:aac5:: with SMTP id i5mr26517718wrc.285.1586947421042; Wed, 15 Apr 2020 03:43:41 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id y15sm23209097wro.68.2020.04.15.03.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 03:43:40 -0700 (PDT) Date: Wed, 15 Apr 2020 12:43:38 +0200 From: Michal Hocko To: Vishal Verma Cc: linux-mm@kvack.org, linux-nvdimm@lists.01.org, David Hildenbrand , Dan Williams , Dave Hansen Subject: Re: [PATCH v3] mm/memory_hotplug: refrain from adding memory into an impossible node Message-ID: <20200415104338.GF4629@dhcp22.suse.cz> References: <20200414235812.6158-1-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414235812.6158-1-vishal.l.verma@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 14-04-20 17:58:12, Vishal Verma wrote: [...] > +static int check_hotplug_node(int nid) > +{ > + int alt_nid; > + > + if (node_possible(nid)) > + return nid; > + > + alt_nid = numa_map_to_online_node(nid); > + if (alt_nid == NUMA_NO_NODE) > + alt_nid = first_online_node; > + WARN_TAINT(1, TAINT_FIRMWARE_WORKAROUND, > + "node %d expected, but was absent from the node_possible_map, using %d instead\n", > + nid, alt_nid); I really do not like this. Why should we try to be clever and change the node id requested by the caller? I would just stick with node_possible check and be done with this. -- Michal Hocko SUSE Labs