From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A69FAC3815B for ; Wed, 15 Apr 2020 12:29:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7602B2137B for ; Wed, 15 Apr 2020 12:29:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7602B2137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1301E8E0017; Wed, 15 Apr 2020 08:29:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E11E8E0001; Wed, 15 Apr 2020 08:29:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F38918E0017; Wed, 15 Apr 2020 08:29:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id D60D68E0001 for ; Wed, 15 Apr 2020 08:29:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 99265180AD802 for ; Wed, 15 Apr 2020 12:29:02 +0000 (UTC) X-FDA: 76710018924.08.step70_6c04f6b4d320e X-HE-Tag: step70_6c04f6b4d320e X-Filterd-Recvd-Size: 4436 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 12:29:02 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id a201so18399449wme.1 for ; Wed, 15 Apr 2020 05:29:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ftXKO5Uq1KJxEgTgHTyrErxInw3k9nxtVAFqlw5s4i4=; b=XZuoTAgCAOP8t3zXvmV2Usm0aKGu5xZ5pJPzYJszfw4nwyHHjGyhcYa3J0xmMEcghS 5JqiooOJgzfAeXOk26yO1rvUK1JawXZhVy54nwoTSKUCu6mh8FVdE3RZyDEWDGWvmHlL pgR30rWhdtZDFdLAV58jqw5de8wHV/Fox+v6THhW4nOyT0Dv6vWXCzm0VPJwodwELpaH 8qRho2Km25hIas6B0f2D8mMgZJHZjLhRd0oSLmSmTfhlWD6Rxd0u5F3AN5Fdez7UGyFN 62M+eIYsixvdwUlRGnvfzJzQHhUHNxcsBpoGhUxJeCPjpvLjWYzWHjl7/C0h3aAaUzUg M7mA== X-Gm-Message-State: AGi0PuaVk9EPHme531iU1z4I3q9jWjtVYI4ufn7omuYAsDCaA7omnMj9 HmqQBpofE7Rs229Pj10f0RQ= X-Google-Smtp-Source: APiQypJZ8bSrRr2PVsjo3hNejerskpCnIaGTRW7Ou6W3HYDnqkfXcuDyayllBwhBvq4MyLdIHHffaA== X-Received: by 2002:a7b:c0d5:: with SMTP id s21mr4965829wmh.107.1586953739505; Wed, 15 Apr 2020 05:28:59 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id n6sm23860479wrs.81.2020.04.15.05.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 05:28:58 -0700 (PDT) Date: Wed, 15 Apr 2020 14:28:57 +0200 From: Michal Hocko To: Leonid Moiseichuk Cc: svc lmoiseichuk , Johannes Weiner , vdavydov.dev@gmail.com, tj@kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, akpm@linux-foundation.org, rientjes@google.com, minchan@kernel.org, vinmenon@codeaurora.org, andriy.shevchenko@linux.intel.com, anton.vorontsov@linaro.org, penberg@kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/2] memcg, vmpressure: expose vmpressure controls Message-ID: <20200415122857.GL4629@dhcp22.suse.cz> References: <20200413215750.7239-1-lmoiseichuk@magicleap.com> <20200414113730.GH4629@dhcp22.suse.cz> <20200414184917.GT4629@dhcp22.suse.cz> <20200415075136.GY4629@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 15-04-20 08:17:42, Leonid Moiseichuk wrote: > As Chris Down stated cgroups v1 frozen, so no API changes in the mainline > kernel. Yes, this is true, _but_ if there are clear shortcomings in the existing vmpressure implementation which could be addressed reasonably then there is no reason to ignore them. [...] > > I still find this very confusing because the amount of used memory is > > not really important. It really only depends on the reclaim activity and > > that is either the memcg or the global reclaim. And you are getting > > critical levels only if the reclaim is failing to reclaim way too many > > pages. > > > > OK, agree from that point of view. > But for larger systems reclaiming happens not so often and we can > use larger window sizes to have better memory utilization approximation. Nobody is saying the the window size has to be fixed. This all can be auto tuned in the kernel. It would, however, require to define what "better utilization approximation" means much more specifically. [...] > > This looks more like a problem of vmpressure implementation than > > something you want to workaround by tuning to me. > > > Basically it is how it works - collect the scanned page and activate worker > activity to update the current level. That is the case only for some vmpressure invocations. And your data suggest that those might lead to misleading results. So this is likely good to focus on and find out whether this can be addressed. -- Michal Hocko SUSE Labs