From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63374C2BA19 for ; Wed, 15 Apr 2020 22:59:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17C822076D for ; Wed, 15 Apr 2020 22:59:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="eNgPPZZH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17C822076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A2D398E0052; Wed, 15 Apr 2020 18:59:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DDFF8E0001; Wed, 15 Apr 2020 18:59:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F2B58E0052; Wed, 15 Apr 2020 18:59:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 753198E0001 for ; Wed, 15 Apr 2020 18:59:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2B9FF180AD807 for ; Wed, 15 Apr 2020 22:59:15 +0000 (UTC) X-FDA: 76711607070.09.air04_50bce07118544 X-HE-Tag: air04_50bce07118544 X-Filterd-Recvd-Size: 5011 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 22:59:14 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id t11so4080180lfe.4 for ; Wed, 15 Apr 2020 15:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0GJj72rOV8U2EAUOLAErCfg2QdniBznpVj0ApYsgoJY=; b=eNgPPZZHcjefzt31MMwn1gNJJm0ooEAsvvYQ85TbXAuxt+32Q9aMwCQWftGnQQF4Yp gxr1pfT7WeJDHdM+AERbF7TX4P8unTnoVYFISyS0T3FAoQ45c64n6R9+bsqezBGNDCSv wSAq/ys+tOpcET5hOw0H5q04wkQYaiKo0UWpWAtfyJ5KeTdds6UlBRYs/CwI9eI1eYcq l9Ir4vfoLW+oqHByJzqwbCwpJrMuceqjff0o76STDz+s0CZmT4CJ+dBBV8TSgiefsAPL k2TZjvdjHHDe4nZ8CK0afIJIpE6AUEWSBlse9LrhFMSiklHGdChjnnbHVN9Sbf6w/FUt X7TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0GJj72rOV8U2EAUOLAErCfg2QdniBznpVj0ApYsgoJY=; b=GO2xDURIx9SBwEHuQzL50+Th1SoX75MVKXNFHf5mVJoPvucJNEUlNXFV/iR7ZdNyYU 2kTV7NiHbD6yPuVhhBAHqs1Ghnu4mZ0fASd6T2yja2BIj8lwOQn+ojR88yIRv9uzVn3h fAh4VJm9SSMPgW4/GjyCQ4Bgy+nfxI7fbsxoT1h4yYj7SDB6p+mtnOeQ+H6XXkKp6rmI XnergskFfHzt9ULM48IUiQ7chxwi7EGJhEwcI22vyf4Rs9UK1XG8SEIJUbFejxV69gRC cUvjgzkWDxCi4VL4E7xkgoDTOtHs7dJOTPDQsNevGG/MWv40CckNVbF2EuX0e7DnOk0s ZXkg== X-Gm-Message-State: AGi0PubQTrKybGDO1DL+X/htY/GkxywyjFI2qWILil1gdDXLmtsCQlOh XwtDA7EcvkxZu89pl0Q0TVwLIJgDR/M= X-Google-Smtp-Source: APiQypIsNgpSZlzWvGdf1lVQnr06ejkzAv36hZyaHFMlHTUdzCW5I5M4tYgDSpF+RQm+MNs6SL3IzA== X-Received: by 2002:a05:6512:318a:: with SMTP id i10mr4361753lfe.96.1586991552822; Wed, 15 Apr 2020 15:59:12 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id q9sm14922879ljm.9.2020.04.15.15.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 15:59:11 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 5FE04102C64; Thu, 16 Apr 2020 01:59:11 +0300 (+03) Date: Thu, 16 Apr 2020 01:59:11 +0300 From: "Kirill A. Shutemov" To: Andrew Morton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Zi Yan , Yang Shi , Ralph Campbell , John Hubbard , William Kucharski , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3, RESEND 6/8] khugepaged: Allow to collapse PTE-mapped compound pages Message-ID: <20200415225911.ryybsmdrtwxngi5h@box> References: <20200413125220.663-1-kirill.shutemov@linux.intel.com> <20200413125220.663-7-kirill.shutemov@linux.intel.com> <20200415144426.a146ef173140f5bc396a6dcd@linux-foundation.org> <20200415215205.eaihc5snfe4ffhju@box> <20200415155259.8be9887c64b1420cfc9b9655@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200415155259.8be9887c64b1420cfc9b9655@linux-foundation.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 15, 2020 at 03:52:59PM -0700, Andrew Morton wrote: > On Thu, 16 Apr 2020 00:52:05 +0300 "Kirill A. Shutemov" wrote: > > > On Wed, Apr 15, 2020 at 02:44:26PM -0700, Andrew Morton wrote: > > > On Mon, 13 Apr 2020 15:52:18 +0300 "Kirill A. Shutemov" wrote: > > > > > > > We can collapse PTE-mapped compound pages. We only need to avoid > > > > handling them more than once: lock/unlock page only once if it's present > > > > in the PMD range multiple times as it handled on compound level. The > > > > same goes for LRU isolation and putback. > > > > > > > > ... > > > > > > > > --- a/mm/khugepaged.c > > > > +++ b/mm/khugepaged.c > > > > @@ -515,17 +515,30 @@ void __khugepaged_exit(struct mm_struct *mm) > > > > > > > > static void release_pte_page(struct page *page) > > > > { > > > > - dec_node_page_state(page, NR_ISOLATED_ANON + page_is_file_cache(page)); > > > > > > I have > > > > > > dec_node_page_state(page, NR_ISOLATED_ANON + page_is_file_lru(page)); > > > > > > here. Is there some prerequisite which I wasn't able to find? > > > > The patchset is on top of v5.6. It has been changed since. See > > 9de4f22a60f7 ("mm: code cleanup for MADV_FREE"). > > > > Look like a trivial fixup is required. > > [7/8] makes a big mess. Can we please have a v4? Sure. Give me a day. -- Kirill A. Shutemov