From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA191C2BA2B for ; Thu, 16 Apr 2020 06:59:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9DB6A20787 for ; Thu, 16 Apr 2020 06:59:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DB6A20787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4A7188E0099; Thu, 16 Apr 2020 02:59:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42F7A8E0001; Thu, 16 Apr 2020 02:59:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F72B8E0099; Thu, 16 Apr 2020 02:59:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 12F2F8E0001 for ; Thu, 16 Apr 2020 02:59:27 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D9AC8442C for ; Thu, 16 Apr 2020 06:59:26 +0000 (UTC) X-FDA: 76712817132.06.view32_35561bdc4ca22 X-HE-Tag: view32_35561bdc4ca22 X-Filterd-Recvd-Size: 6161 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Apr 2020 06:59:26 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id u9so1234442pfm.10 for ; Wed, 15 Apr 2020 23:59:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5dFbWwPMLFdLLdwYDe+nstRRn0RE7K4B+Qa2HC0tOOY=; b=lWoVNXVxq3tR3EdJ7ko7QS3K4PnhPSS8kTWTb4LzKlVlkuZP5bHcpqrUFjz4BYthaJ se/ijgbkF/bY0LA2YVax0AUHTgTiARq01R2bKYHkhtli/cKK2uWF/i27Sx9pLcCfNbbf 4LVVidN67MThqbrnLzCMwv3dhdXCgf0rEGgr2vJ8BKoRMVC/q6b139SnfoNVOJYrsELj mFBOTLaOw1N8OXTqZaVRcwggSF9DG8kGxwTQeqAx21e2SDzhu9T2dOXEIUbZXvOTtACk RVd7ASvEKbXzZVTptTalIdngSwYe47JxCVngU9YGz33mbOe1bR/d+jDrfLNymcgLdicr pxtw== X-Gm-Message-State: AGi0PuYcLKEiI/+WRAPgsklLfSZxxSOnDpGkYlGMdHH/29lcG7/0fRe4 D9PnKr/dnk/rswmlusygvSk= X-Google-Smtp-Source: APiQypJZGq5fLgrVy29taLiihHKxD4A1T8eXY4M60RzcYsImGLylhhpJZd5BDHXDMlwu9qPWflNP1A== X-Received: by 2002:a63:4526:: with SMTP id s38mr7330142pga.410.1587020364470; Wed, 15 Apr 2020 23:59:24 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id v24sm15687796pfm.94.2020.04.15.23.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 23:59:23 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 6A84140277; Thu, 16 Apr 2020 06:59:22 +0000 (UTC) Date: Thu, 16 Apr 2020 06:59:22 +0000 From: Luis Chamberlain To: Emanuele Giuseppe Esposito Cc: linux-nfs@vger.kernel.org, Paolo Bonzini , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Greg Kroah-Hartman , Robert Richter , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Alexander Viro , Ian Kent , Joel Becker , Christoph Hellwig , "Rafael J. Wysocki" , Matthew Garrett , Ard Biesheuvel , Miklos Szeredi , Mike Kravetz , Mark Fasheh , Joseph Qi , Alexey Dobriyan , Kees Cook , Iurii Zaikin , Anton Vorontsov , Colin Cross , Tony Luck , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Hugh Dickins , Andrew Morton , Trond Myklebust , Anna Schumaker , "J. Bruce Fields" , Chuck Lever , "David S. Miller" , Jakub Kicinski , James Morris , "Serge E. Hallyn" , John Johansen , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, oprofile-list@lists.sf.net, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 0/8] Simplefs: group and simplify linux fs code Message-ID: <20200416065922.GS11244@42.do-not-panic.com> References: <20200414124304.4470-1-eesposit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414124304.4470-1-eesposit@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 14, 2020 at 02:42:54PM +0200, Emanuele Giuseppe Esposito wrote: > This series of patches introduce wrappers for functions, > arguments simplification in functions calls and most importantly > groups duplicated code in a single header, simplefs, to avoid redundancy > in the linux fs, especially debugfs and tracefs. The general goal seems worthy, but here I don't see explained why hasn't this gone through libfs, and what the intention was long term. For instance, you added some other generalizations which you have found. It was not clear that this was the goal here, to expand on these paths. What if common code on fs is found which are not part of debugfs and tracefs, how does one decide if to move to libfs or simplefs? Luis