From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 878EAC2BB55 for ; Thu, 16 Apr 2020 11:21:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 52F1821734 for ; Thu, 16 Apr 2020 11:21:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QG9hqnmQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52F1821734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D302A8E00A5; Thu, 16 Apr 2020 07:21:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D07898E0001; Thu, 16 Apr 2020 07:21:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8088E00A5; Thu, 16 Apr 2020 07:21:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id A3C3B8E0001 for ; Thu, 16 Apr 2020 07:21:23 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 67BB4824556B for ; Thu, 16 Apr 2020 11:21:23 +0000 (UTC) X-FDA: 76713477246.19.cake68_c1a9d3b19259 X-HE-Tag: cake68_c1a9d3b19259 X-Filterd-Recvd-Size: 1993 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Apr 2020 11:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PXE8WU57/ob/uE0JQIhn8obGmSq2L0WMhMYM6Ggi9hs=; b=QG9hqnmQ2U6TcuHhi0YZD5a0Fc SKNu5+WgPPNLAm90YCfmYDZt5Ff5mO12bJtUs1YUA+8flAh6SLN5R9rKhzUbC80uNYPneRDJOPuNn umAZOuxsrYiIOTzl+zra/6DifnN6yDLNd8KgnFjvHs0uMTWl+ijzalG9J3UvWAMV1k2QgPEiApWWM C6nHXj/06VZJbr2mYOrTlx3+FErdsVxmjciu2v/8Ib8lDZaMWdVKcUKJun+B2aYcCC/xn1qsSJh5a p4JpMfWWy7NT74pV8OQN04TsgjhV41eQ83cHwOLdFs8ZZ4HUsw7A8cd8gG78YKNeOSP92JQyho8iP nAlIhNPg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP2a3-0008Sa-SC; Thu, 16 Apr 2020 11:21:15 +0000 Date: Thu, 16 Apr 2020 04:21:15 -0700 From: Matthew Wilcox To: Muchun Song Cc: akpm@linux-foundation.org, Markus.Elfring@web.de, david@redhat.com, ktkhai@virtuozzo.com, yang.shi@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiongchun Duan Subject: Re: [PATCH v4] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled Message-ID: <20200416112115.GF5820@bombadil.infradead.org> References: <20200416025034.29780-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416025034.29780-1-songmuchun@bytedance.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 16, 2020 at 10:50:34AM +0800, Muchun Song wrote: > + /** > + * If the vma is out of date, we do not need to > + * continue. > + */ This comment is not in kernel-doc format and should not start with '/**'.