From: Matthew Wilcox <willy@infradead.org>
To: Will Deacon <will@kernel.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH 1/2] mm: Remove definition of clear_bit_unlock_is_negative_byte
Date: Thu, 16 Apr 2020 07:31:05 -0700 [thread overview]
Message-ID: <20200416143105.GG5820@bombadil.infradead.org> (raw)
In-Reply-To: <20200416124536.GA32565@willie-the-truck>
On Thu, Apr 16, 2020 at 01:45:39PM +0100, Will Deacon wrote:
> Sorry I missed this, I'm over on @kernel.org now and don't have access to
> my old @arm.com address anymore.
Oops. Shame they haven't started bouncing it yet, so I didn't know.
> > -static inline bool clear_bit_unlock_is_negative_byte(long nr, volatile void *mem)
> > -{
> > - clear_bit_unlock(nr, mem);
> > - /* smp_mb__after_atomic(); */
> > - return test_bit(PG_waiters, mem);
> > -}
>
> I'd really like to do this, but I worry that the generic definition still
> isn't available on all architectures depending on how they pull together
> their bitops.h. Have you tried building for alpha or s390? At a quick
> glance, they look like they might fall apart :(
I haven't, but fortunately the 0day build bot has! It built both s390 and
alpha successfully (as well as 120+ other configurations).
next prev parent reply other threads:[~2020-04-16 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 12:24 [PATCH 0/2] Make PageWriteback use the PageLocked optimisation Matthew Wilcox
2020-03-26 12:24 ` [PATCH 1/2] mm: Remove definition of clear_bit_unlock_is_negative_byte Matthew Wilcox
2020-04-16 12:45 ` Will Deacon
2020-04-16 14:31 ` Matthew Wilcox [this message]
2020-03-26 12:24 ` [PATCH 2/2] mm: Use clear_bit_unlock_is_negative_byte for PageWriteback Matthew Wilcox
2020-03-26 12:40 ` Jan Kara
2020-03-26 12:44 ` Matthew Wilcox
2020-03-27 10:46 ` William Kucharski
2020-03-26 17:11 ` Christoph Hellwig
2020-03-26 17:16 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416143105.GG5820@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=will.deacon@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).