From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6947C2BB55 for ; Thu, 16 Apr 2020 15:52:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8375B21927 for ; Thu, 16 Apr 2020 15:52:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="bcbScya9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8375B21927 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 167CD8E00C2; Thu, 16 Apr 2020 11:52:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 119958E00BC; Thu, 16 Apr 2020 11:52:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02DB88E00C2; Thu, 16 Apr 2020 11:52:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id E1E968E00BC for ; Thu, 16 Apr 2020 11:52:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8FB7C824556B for ; Thu, 16 Apr 2020 15:52:10 +0000 (UTC) X-FDA: 76714159620.29.berry42_300dde1b55a0b X-HE-Tag: berry42_300dde1b55a0b X-Filterd-Recvd-Size: 4069 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Apr 2020 15:52:10 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id w145so5972928lff.3 for ; Thu, 16 Apr 2020 08:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FfAE3K8uyhxoa402bGrMeSvXqOseWRk+R6RkoAmXNwQ=; b=bcbScya9mobQkne7CdnBOoVV0Pajye6caK4t9DX8OVKbpk4KPaho2o6R7qNTWu5hnS pnX3o2qdBH68qltybzBhi3TbamMqIgkeQ5uVLW/l+hzuqqCtAYuUiJ7hUJyF3fKI7Vvl UxZBC24nupXXkjC5dj6Wxo4LhFM+Dnwu3vdLc/ZcAac2M9dNVfNoNra8OD5jYJjHJ75m oEcYZ3ZVRC1k/pC4TWuqO3PMHvCmaf5O1YZKzraCCc6lletIanyHf+q7M41QIaxksWlX qAZfNCcK3TUwerJja/lIYutfXFqR80lcGYOsiXSp5aTtmCyhuAiZ9MluAoLWqb4AfwNy Z1Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FfAE3K8uyhxoa402bGrMeSvXqOseWRk+R6RkoAmXNwQ=; b=btwY5SYzozQ9Yst5jjBJrV1ysq799QamT8MGgUrcrXcDvEjgAMPhFtUN8BIW/p5o9+ 0qrN24zsJOdQGYzvUP2hQQj53G4e98Y+xxBIt04p4rY5YBtZ1NxP+jmn5STQgJ3MnLd1 OHxMPl0H2v3jswEvzUw84+slvsknW8K3A71Y/0d+ucC5KgNhq0AHkLtSvnK3gYkzmxct PwZXGCQYK5uFJDuqBYcRnOvw+qCtHyq/XoUR5agbJEubo1aT7VXiQQJs5bsHj7zlcUmh IjPf7t09832GBZMYHKpPM4PtF9AruQoCzxBooU9oLnVV6Mhq+z9JjCVlZKvvPi3QisZ3 KP+A== X-Gm-Message-State: AGi0PuaCQshK+uW63KBIkds73UvOnro8IbJRZ0w2tLPlJBAfbC7A9CYn eNkp+NI+PE/EyicA7oPHDoy9CkRrlCk= X-Google-Smtp-Source: APiQypKWeWNUzL67I509RIb9cMtVwbJ40Fy04qdiLCdyRp3hf4Kij6z4C0dlcJSnwDWpHBjQm6okLQ== X-Received: by 2002:ac2:5e86:: with SMTP id b6mr6319687lfq.65.1587052328016; Thu, 16 Apr 2020 08:52:08 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id w16sm15683130lfk.49.2020.04.16.08.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2020 08:52:07 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 0F317102E22; Thu, 16 Apr 2020 18:52:06 +0300 (+03) Date: Thu, 16 Apr 2020 18:52:06 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: "Kirill A. Shutemov" , akpm@linux-foundation.org, Andrea Arcangeli , Zi Yan , Ralph Campbell , John Hubbard , William Kucharski , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3, RESEND 8/8] khugepaged: Introduce 'max_ptes_shared' tunable Message-ID: <20200416155206.bqpd5p45oud4chg6@box> References: <20200413125220.663-1-kirill.shutemov@linux.intel.com> <20200413125220.663-9-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 15, 2020 at 02:25:30PM -0700, Yang Shi wrote: > > @@ -595,6 +626,12 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > > VM_BUG_ON_PAGE(!PageAnon(page), page); > > + if (page_mapcount(page) > 1 && > > + ++shared > khugepaged_max_ptes_shared) { > > + result = SCAN_EXCEED_SHARED_PTE; > > It may be better to extract the check into a helper? For example, bool > exceed_max_ptes_shared(struct page)? It might be reasonable as part of wider cleanup: the same has to be done to khugepaged_max_ptes_none and khugepaged_max_ptes_swap. Volunteers? :P -- Kirill A. Shutemov