From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE5BC2D0EF for ; Fri, 17 Apr 2020 04:41:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BF4422250 for ; Fri, 17 Apr 2020 04:41:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="chsZ72cL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BF4422250 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E68C78E0003; Fri, 17 Apr 2020 00:41:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF2818E0001; Fri, 17 Apr 2020 00:41:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE0C58E0003; Fri, 17 Apr 2020 00:41:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id B197A8E0001 for ; Fri, 17 Apr 2020 00:41:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6B429180ACEF0 for ; Fri, 17 Apr 2020 04:41:48 +0000 (UTC) X-FDA: 76716099096.16.crib28_49f1e3ff58a48 X-HE-Tag: crib28_49f1e3ff58a48 X-Filterd-Recvd-Size: 2338 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Fri, 17 Apr 2020 04:41:47 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C922C20857; Fri, 17 Apr 2020 04:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587098507; bh=q0+ZrS4en2WNXGJtxGr4zom20hpkM8cyAL17PgaJesM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=chsZ72cLuaZOsF85xKIeiQ2NcLV4bwY/tWjPX3CSdbmavw7LUV5sbqUxvUv3pKrQL pO9g8kx6HncpuObVnnb9Qc1rBPDlEqc2qxS/18ORNBvDyZDWHorL1Dw/IKqcaubQCk +J6sF5B508LFRRDLe3BIrKvf8MdCLGfxK53ljlbI= Date: Thu, 16 Apr 2020 21:41:45 -0700 From: Andrew Morton To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Zi Yan , Yang Shi , Ralph Campbell , John Hubbard , William Kucharski , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 4/8] khugepaged: Drain LRU add pagevec after swapin Message-Id: <20200416214145.bfbb1afcc7a632e8cafdf203@linux-foundation.org> In-Reply-To: <20200416160026.16538-5-kirill.shutemov@linux.intel.com> References: <20200416160026.16538-1-kirill.shutemov@linux.intel.com> <20200416160026.16538-5-kirill.shutemov@linux.intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 16 Apr 2020 19:00:22 +0300 "Kirill A. Shutemov" wrote: > __collapse_huge_page_isolate() may fail due to extra pin in the LRU add > pagevec. It's pretty common for swapin case: we swap in pages just to > fail due to the extra pin. > > Drain LRU add pagevec on successful swapin. I don't see how this patch can do anything to prevent __collapse_huge_page_isolate() from failing, which is what the changelog implies. Can we have a more detailed changelog, please?