From: Andrey Ignatov <rdna@fb.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-fsdevel@vger.kernel.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>
Subject: Re: [PATCH 6/6] sysctl: pass kernel pointers to ->proc_handler
Date: Fri, 17 Apr 2020 15:38:28 -0700 [thread overview]
Message-ID: <20200417223828.GA41441@rdna-mbp> (raw)
In-Reply-To: <20200417195015.GO5820@bombadil.infradead.org>
Matthew Wilcox <willy@infradead.org> [Fri, 2020-04-17 12:50 -0700]:
> On Fri, Apr 17, 2020 at 12:39:10PM -0700, Andrey Ignatov wrote:
> > Though it breaks tools/testing/selftests/bpf/test_sysctl.c. I spent some
> > time debugging and found a couple of problems -- see below. But there is
> > something else .. Still I figured it's a good idea to give an early
> > heads-up.
>
> "see below"? Really? You're going to say that and then make people
> scroll through thousands of lines of quoted material to find your new
> contributions? Please, learn to trim appropriately.
Ack.
>
> Here's about what you should have sent:
Thanks.
--
Andrey Ignatov
next prev parent reply other threads:[~2020-04-17 22:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 6:41 pass kernel pointers to the sysctl ->proc_handler method Christoph Hellwig
2020-04-17 6:41 ` [PATCH 1/6] bpf-cgroup: remove unused exports Christoph Hellwig
2020-04-17 6:41 ` [PATCH 2/6] firmware_loader: " Christoph Hellwig
2020-04-17 7:43 ` Greg Kroah-Hartman
2020-04-17 7:48 ` Christoph Hellwig
2020-04-17 6:41 ` [PATCH 3/6] mm: remove watermark_boost_factor_sysctl_handler Christoph Hellwig
2020-04-17 6:41 ` [PATCH 4/6] sysctl: remove all extern declaration from sysctl.c Christoph Hellwig
2020-04-22 12:33 ` Eric W. Biederman
2020-04-22 17:26 ` Christoph Hellwig
2020-04-17 6:41 ` [PATCH 5/6] sysctl: avoid forward declarations Christoph Hellwig
2020-04-17 6:41 ` [PATCH 6/6] sysctl: pass kernel pointers to ->proc_handler Christoph Hellwig
2020-04-17 7:45 ` Greg Kroah-Hartman
2020-04-17 18:17 ` Matthew Wilcox
2020-04-21 7:42 ` Christoph Hellwig
2020-04-17 19:39 ` Andrey Ignatov
2020-04-17 19:50 ` Matthew Wilcox
2020-04-17 22:38 ` Andrey Ignatov [this message]
2020-04-21 7:55 ` Christoph Hellwig
2020-04-17 22:36 ` [Potential Spoof] " Andrey Ignatov
2020-04-17 18:00 ` pass kernel pointers to the sysctl ->proc_handler method Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417223828.GA41441@rdna-mbp \
--to=rdna@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).