From: Michal Hocko <mhocko@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH 3/3] memcg oom: bail out from the charge path if no victim found
Date: Mon, 20 Apr 2020 13:10:13 +0200 [thread overview]
Message-ID: <20200420111013.GL27314@dhcp22.suse.cz> (raw)
In-Reply-To: <CALOAHbC656aNU0-nOSLtEVyPqxKHNEaVUG5r9evSUuq009i_Mw@mail.gmail.com>
On Mon 20-04-20 18:51:50, Yafang Shao wrote:
> On Mon, Apr 20, 2020 at 6:31 PM Michal Hocko <mhocko@kernel.org> wrote:
[...]
> > If this turns out to be infeasible then we should be addressing that
> > problem for all possible cases and that means to allow breaking the
> > oom_score_adj contract and kill also hidden tasks.
>
> Breaking the oom_score_adj contract seems another possible way, that
> would be accepted by the user - misconfiguration or bugs in user code
> should be punished. IOW this is the fault of the user and the kernel
> should tell the user the result of this fault.
This is not how the kernel behaves in the vast majority of cases. We
allow users to shoot their feet. Especially for root only interfaces.
We simply rely that admins know what they are doing.
So let me repeat there has to be a very strong justification - e.g. it
is impossible to remove oom_score_adj OOM killer disabling for some
reason and this really happens out there in real deployments. We are
surely not going to break the contract based on artificial misconfigured
test cases.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2020-04-20 11:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 15:13 [PATCH 0/3] memcg oom: bail out from the charge path if no victim found Yafang Shao
2020-04-18 15:13 ` [PATCH 1/3] mm: change the return type of out_of_memory() Yafang Shao
2020-04-18 15:13 ` [PATCH 2/3] mm, memcg: introduce a new helper task_in_memcg_oom_set() Yafang Shao
2020-04-18 15:13 ` [PATCH 3/3] memcg oom: bail out from the charge path if no victim found Yafang Shao
2020-04-20 8:13 ` Michal Hocko
2020-04-20 8:52 ` Yafang Shao
2020-04-20 9:14 ` Michal Hocko
2020-04-20 9:58 ` Yafang Shao
2020-04-20 10:31 ` Michal Hocko
2020-04-20 10:51 ` Yafang Shao
2020-04-20 11:10 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420111013.GL27314@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).