From: Luis Chamberlain <mcgrof@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk,
gregkh@linuxfoundation.org, rostedt@goodmis.org,
mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com,
nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com,
yukuai3@huawei.com, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
Hannes Reinecke <hare@suse.com>, Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH v2 04/10] block: revert back to synchronous request_queue removal
Date: Mon, 20 Apr 2020 18:59:43 +0000 [thread overview]
Message-ID: <20200420185943.GM11244@42.do-not-panic.com> (raw)
In-Reply-To: <749d56bd-1d66-e47b-a356-8d538e9c99b4@acm.org>
On Sun, Apr 19, 2020 at 03:23:31PM -0700, Bart Van Assche wrote:
> On 4/19/20 12:45 PM, Luis Chamberlain wrote:
> > +/**
> > + * blk_put_queue - decrement the request_queue refcount
> > + *
> > + * @q: the request_queue structure to decrement the refcount for
> > + *
>
> How about following the example from Documentation/doc-guide/kernel-doc.rst
> and not leaving a blank line above the function argument documentation?
Sure.
> > + * Decrements the refcount to the request_queue kobject, when this reaches
> ^^
> of?
> > + * 0 we'll have blk_release_queue() called. You should avoid calling
> > + * this function in atomic context but if you really have to ensure you
> > + * first refcount the block device with bdgrab() / bdput() so that the
> > + * last decrement happens in blk_cleanup_queue().
> > + */
>
> Is calling bdgrab() and bdput() an option from a context in which it is not
> guaranteed that the block device is open?
If the block device is not open, nope. For that blk_get_queue() can
be used, and is used by the block layer. This begs the question:
Do we have *drivers* which requires access to the request_queue from
atomic context when the block device is not open?
> Does every context that calls blk_put_queue() also call blk_cleanup_queue()?
Nope.
> How about avoiding confusion by changing the last sentence of that comment
> into something like the following: "The last reference must not be dropped
> from atomic context. If it is necessary to call blk_put_queue() from atomic
> context, make sure that that call does not decrease the request queue
> refcount to zero."
This would be fine, if not for the fact that it seems worthy to also ask
ourselves if we even need blk_get_queue() / blk_put_queue() exported for
drivers.
I haven't yet finalized my review of this, but planting the above
comment cements the idea further that it is possible. Granted, I think
its fine as -- that is our current use case and best practice. Removing
the export for blk_get_queue() / blk_put_queue() should entail reviewing
each driver caller and ensuring that it is not needed. And that is not
done yet, and should be considered a separate effort.
> > /**
> > * blk_cleanup_queue - shutdown a request queue
> > + *
> > * @q: request queue to shutdown
> > *
>
> How about following the example from Documentation/doc-guide/kernel-doc.rst
> and not leaving a blank line above the function argument documentation?
Will do.
> > * Mark @q DYING, drain all pending requests, mark @q DEAD, destroy and
> > * put it. All future requests will be failed immediately with -ENODEV.
> > + *
> > + * You should not call this function in atomic context. If you need to
> > + * refcount a request_queue in atomic context, instead refcount the
> > + * block device with bdgrab() / bdput().
>
> Surrounding blk_cleanup_queue() with bdgrab() / bdput() does not help. This
> blk_cleanup_queue() must not be called from atomic context.
I'll just remove that.
>
> > /**
> > - * __blk_release_queue - release a request queue
> > - * @work: pointer to the release_work member of the request queue to be released
> > + * blk_release_queue - release a request queue
> > + *
> > + * This function is called as part of the process when a block device is being
> > + * unregistered. Releasing a request queue starts with blk_cleanup_queue(),
> > + * which set the appropriate flags and then calls blk_put_queue() as the last
> > + * step. blk_put_queue() decrements the reference counter of the request queue
> > + * and once the reference counter reaches zero, this function is called to
> > + * release all allocated resources of the request queue.
> > *
> > - * Description:
> > - * This function is called when a block device is being unregistered. The
> > - * process of releasing a request queue starts with blk_cleanup_queue, which
> > - * set the appropriate flags and then calls blk_put_queue, that decrements
> > - * the reference counter of the request queue. Once the reference counter
> > - * of the request queue reaches zero, blk_release_queue is called to release
> > - * all allocated resources of the request queue.
> > + * This function can sleep, and so we must ensure that the very last
> > + * blk_put_queue() is never called from atomic context.
> > + *
> > + * @kobj: pointer to a kobject, who's container is a request_queue
> > */
>
> Please follow the style used elsewhere in the kernel and move function
> argument documentation just below the line with the function name.
Sure, thanks for the review.
Luis
next prev parent reply other threads:[~2020-04-20 18:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 19:45 [PATCH v2 00/10] block: fix blktrace debugfs use after free Luis Chamberlain
2020-04-19 19:45 ` [PATCH v2 01/10] block: move main block debugfs initialization to its own file Luis Chamberlain
2020-04-19 21:06 ` Bart Van Assche
2020-04-19 19:45 ` [PATCH v2 02/10] blktrace: move blktrace debugfs creation to helper function Luis Chamberlain
2020-04-19 21:11 ` Bart Van Assche
2020-04-22 7:12 ` Christoph Hellwig
2020-04-19 19:45 ` [PATCH v2 03/10] blktrace: fix debugfs use after free Luis Chamberlain
2020-04-19 21:55 ` Bart Van Assche
2020-04-20 0:04 ` Luis Chamberlain
2020-04-20 0:38 ` Bart Van Assche
2020-04-20 18:46 ` Luis Chamberlain
2020-04-20 20:16 ` Greg KH
2020-04-20 20:41 ` Luis Chamberlain
2020-04-21 7:00 ` Greg KH
2020-04-22 7:28 ` Luis Chamberlain
2020-04-22 9:43 ` Ming Lei
2020-04-22 10:31 ` Luis Chamberlain
2020-04-24 23:47 ` Luis Chamberlain
2020-04-22 7:29 ` Christoph Hellwig
2020-04-22 7:34 ` Luis Chamberlain
2020-04-22 7:27 ` Christoph Hellwig
2020-04-22 7:48 ` Luis Chamberlain
2020-04-22 8:10 ` Christoph Hellwig
2020-04-22 8:26 ` Luis Chamberlain
2020-04-19 19:45 ` [PATCH v2 04/10] block: revert back to synchronous request_queue removal Luis Chamberlain
2020-04-19 22:23 ` Bart Van Assche
2020-04-20 18:59 ` Luis Chamberlain [this message]
2020-04-20 21:11 ` Bart Van Assche
2020-04-20 21:51 ` Luis Chamberlain
2020-04-19 19:45 ` [PATCH v2 05/10] blktrace: upgrade warns to BUG_ON() on unexpected circmunstances Luis Chamberlain
2020-04-19 22:50 ` Bart Van Assche
2020-04-19 23:07 ` Luis Chamberlain
2020-04-20 23:20 ` Steven Rostedt
2020-04-19 19:45 ` [PATCH v2 06/10] blk-debugfs: upgrade warns to BUG_ON() if directory is already found Luis Chamberlain
2020-04-20 11:36 ` Greg KH
2020-04-25 11:43 ` [blk] 90d38c0e30: kernel_BUG_at_block/blk-debugfs.c kernel test robot
2020-04-19 19:45 ` [PATCH v2 07/10] blktrace: move debugfs file creation to its own function Luis Chamberlain
2020-04-19 22:55 ` Bart Van Assche
2020-04-20 11:37 ` Greg KH
2020-04-19 19:45 ` [PATCH v2 08/10] blktrace: add checks for created debugfs files on setup Luis Chamberlain
2020-04-19 22:57 ` Bart Van Assche
2020-04-19 23:05 ` Luis Chamberlain
2020-04-19 23:17 ` Bart Van Assche
2020-04-20 11:40 ` Greg KH
2020-04-20 18:44 ` Luis Chamberlain
2020-04-20 20:11 ` Greg KH
2020-04-20 20:20 ` Luis Chamberlain
2020-04-21 6:55 ` Greg KH
2020-04-20 11:39 ` Greg KH
2020-04-19 19:45 ` [PATCH v2 09/10] block: panic if block debugfs dir is not created Luis Chamberlain
2020-04-19 23:08 ` Bart Van Assche
2020-04-20 11:38 ` Greg KH
2020-04-19 19:45 ` [PATCH v2 10/10] block: put_device() if device_add() fails Luis Chamberlain
2020-04-19 23:40 ` Bart Van Assche
2020-04-24 22:32 ` Luis Chamberlain
2020-04-25 1:58 ` Bart Van Assche
2020-04-25 2:12 ` Luis Chamberlain
2020-04-19 19:48 ` [PATCH v2 00/10] block: fix blktrace debugfs use after free Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420185943.GM11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=ming.lei@redhat.com \
--cc=mingo@redhat.com \
--cc=nstange@suse.de \
--cc=osandov@fb.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).