From: Matthew Wilcox <willy@infradead.org>
To: Michel Lespinasse <walken@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Liam Howlett <Liam.Howlett@oracle.com>,
Jerome Glisse <jglisse@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Daniel Jordan <daniel.m.jordan@oracle.com>
Subject: Re: [PATCH v4 06/10] mmap locking API: convert nested write lock sites
Date: Mon, 20 Apr 2020 12:33:10 -0700 [thread overview]
Message-ID: <20200420193310.GF5820@bombadil.infradead.org> (raw)
In-Reply-To: <20200415004353.130248-7-walken@google.com>
On Tue, Apr 14, 2020 at 05:43:49PM -0700, Michel Lespinasse wrote:
> @@ -47,7 +48,7 @@ static inline void activate_mm(struct mm_struct *old, struct mm_struct *new)
> * when the new ->mm is used for the first time.
> */
> __switch_mm(&new->context.id);
> - down_write_nested(&new->mmap_sem, 1);
> + mmap_write_lock_nested(new, 1);
This should have already been using SINGLE_DEPTH_NESTING. 1 is
uninformative.
next prev parent reply other threads:[~2020-04-20 19:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 0:43 [PATCH v4 00/10] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 01/10] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-04-20 19:48 ` Davidlohr Bueso
2020-04-21 0:48 ` Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 02/10] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-04-20 19:51 ` Davidlohr Bueso
2020-04-15 0:43 ` [PATCH v4 03/10] DMA reservations: " Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 06/10] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-04-20 18:19 ` Daniel Jordan
2020-04-20 19:33 ` Matthew Wilcox [this message]
2020-04-21 0:51 ` Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 07/10] mmap locking API: add mmap_read_trylock_non_owner() Michel Lespinasse
2020-04-20 18:22 ` Daniel Jordan
2020-04-20 19:23 ` Matthew Wilcox
2020-04-21 0:55 ` Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-04-20 18:23 ` Daniel Jordan
2020-04-20 19:28 ` Matthew Wilcox
2020-04-21 0:57 ` Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 09/10] mmap locking API: use lockdep_assert_held Michel Lespinasse
2020-04-21 2:35 ` Matthew Wilcox
2020-04-15 0:43 ` [PATCH v4 10/10] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-04-20 18:28 ` Daniel Jordan
2020-04-21 5:33 ` kbuild test robot
2020-04-21 22:19 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420193310.GF5820@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=dave@stgolabs.net \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).