From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B248FC54FC9 for ; Tue, 21 Apr 2020 05:42:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6FC8E208E4 for ; Tue, 21 Apr 2020 05:42:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ApJOmYR1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FC8E208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F10308E0005; Tue, 21 Apr 2020 01:42:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E994F8E0003; Tue, 21 Apr 2020 01:42:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D88AC8E0005; Tue, 21 Apr 2020 01:42:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id BE7B18E0003 for ; Tue, 21 Apr 2020 01:42:13 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7C7AE8248D7C for ; Tue, 21 Apr 2020 05:42:13 +0000 (UTC) X-FDA: 76730766546.28.skin59_6aaea48b60d4c X-HE-Tag: skin59_6aaea48b60d4c X-Filterd-Recvd-Size: 2559 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 05:42:12 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7544A2084D; Tue, 21 Apr 2020 05:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587447732; bh=2gulgVkFfAjn3Pl1PNqXRXmkM/QzduOVT11dMu8o86o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ApJOmYR1uYAyNlSBQToll/A86aHlF3kQ/tdWHawXyGpKjOxTqiRWCqHSR3WazJzIA 4L+nLEixqzeyYNqXfuV8TjK7idDUh5mHndFGgD9WMc/H8gSw+Vy/J9jJ49qwecfb3F M7IdSAdFh4D9we0/ZFSI3sw35uAquW5tJmZTokec= Date: Mon, 20 Apr 2020 22:42:10 -0700 From: Andrew Morton To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org, Gao Xiang , Dave Chinner , William Kucharski , Chao Yu Subject: Re: [PATCH v11 19/25] erofs: Convert compressed files from readpages to readahead Message-Id: <20200420224210.dff005bc62957a4d81d58226@linux-foundation.org> In-Reply-To: <20200414150233.24495-20-willy@infradead.org> References: <20200414150233.24495-1-willy@infradead.org> <20200414150233.24495-20-willy@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Apr 2020 08:02:27 -0700 Matthew Wilcox wrote: > > Use the new readahead operation in erofs. > Well this is exciting. fs/erofs/data.c: In function erofs_raw_access_readahead: fs/erofs/data.c:149:18: warning: last_block may be used uninitialized in this function [-Wmaybe-uninitialized] *last_block + 1 != current_block) { It seems to be a preexisting bug, which your patch prompted gcc-7.2.0 to notice. erofs_read_raw_page() goes in and uses *last_block, but neither of its callers has initialized it. Could the erofs maintainers please take a look?