From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65240C54FCC for ; Mon, 20 Apr 2020 22:45:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E673E206F4 for ; Mon, 20 Apr 2020 22:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RoiiOcB7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E673E206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D1BF8E0006; Mon, 20 Apr 2020 18:45:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 681C48E0003; Mon, 20 Apr 2020 18:45:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 570948E0006; Mon, 20 Apr 2020 18:45:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 3D4478E0003 for ; Mon, 20 Apr 2020 18:45:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E97AC8245571 for ; Mon, 20 Apr 2020 22:45:52 +0000 (UTC) X-FDA: 76729717344.06.limit70_6d87a1bbcf527 X-HE-Tag: limit70_6d87a1bbcf527 X-Filterd-Recvd-Size: 5728 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 22:45:52 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id t3so12679665qkg.1 for ; Mon, 20 Apr 2020 15:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9xmOf4Umuq6m4lJGuspkDPc0ESVbQZihn8MKwxQyg/c=; b=RoiiOcB7OI/5dJtFz1uBcblFq9lzwzIOPR1UztvxR+8AiKpU2wTOko9Le1WnkPDsc/ 6ZmYm0DLZ1ufAj6v/RGKRpZLkP15ZmnwuAgWA9+ywb4JrTtYinbpfesZ6PDxuErL7Aiu JopTuZJ5KIsftHFNPh/oq3TuJqsux7iF0xJcVzHY9u19yYMb6FYOke6Ao05LBBKAbLQ8 V98OFMvsWSta+C1Vk7oSap89s26EkJcrCapcaSFnIP/0ptmxKP5vngfZYYxsCHqSrQ7X 8mhV520Gc/2jAioB3y98ZUxl4UrkxGOyaYUSs2Tkm48NP9Te65N7BwbY230G/Vvfz30k mXsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9xmOf4Umuq6m4lJGuspkDPc0ESVbQZihn8MKwxQyg/c=; b=i6fdbZn+67TLfIyH5p6aovt7KQAXdMjMmYFQiKjoUmva9JYALYPipJfYbds4pTH7Dy IGP83wpJNhojTgsQPuF1Ev302ehcAJVhGyUe3aK6qForWhUomZhmpnqxruXXuBTVomMo Ul1PdPIcrxPIRisx5FZ7VtkNHtNDon2mHuuWW6VnX+zxTk8wwld4auv8+eMF51cfteeo lu4dUBFIhVi6c0hZu2Oh4S1E1bj6bDta6CvAm8CUXbdZVnAauEBqn8scA/i8cIy+m89b M2V5fobz6Tvt7T+FmLRYq0A6qzYMApLjEsFaD+O1Qpj9w4SYB32iP6ye5pUC4yZOfBNk 0RXg== X-Gm-Message-State: AGi0PuaOQALRShhc6H+FxWRhVvlK5AkEx+oKv1vY7scrcXqiwKOaJdtZ CqZ3HJhLxQYaBD3kCQCDByo= X-Google-Smtp-Source: APiQypKyuSaw2/RF4fyPsAd6mPZEWw5wtSXhRamnzSlmhenMoLOZDkl71skJhGarMYbqnOunHMIMjA== X-Received: by 2002:a05:620a:15e8:: with SMTP id p8mr4601178qkm.331.1587422752009; Mon, 20 Apr 2020 15:45:52 -0700 (PDT) Received: from dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com ([2620:10d:c091:480::1:b0d9]) by smtp.gmail.com with ESMTPSA id u190sm636744qkb.102.2020.04.20.15.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 15:45:51 -0700 (PDT) Date: Mon, 20 Apr 2020 18:45:49 -0400 From: Dan Schatzberg To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Yang Shi , Tetsuo Handa , Naresh Kamboju , linux-mm , Mel Gorman , Michal Hocko Subject: Re: fs/buffer.c: WARNING: alloc_page_buffers while mke2fs Message-ID: <20200420224549.GA7230@dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com> References: <0a37bb7d-18a7-c43c-52a5-f13a34decf69@i-love.sakura.ne.jp> <20200303202623.GA68565@cmpxchg.org> <20200303210632.GC68565@cmpxchg.org> <20200303162948.a383cb88c4a1b0bfd3817798@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 20, 2020 at 09:41:33AM -0700, Shakeel Butt wrote: > On Tue, Mar 3, 2020 at 4:29 PM Andrew Morton wrote: > > > > On Tue, 3 Mar 2020 15:22:00 -0800 Shakeel Butt wrote: > > > > > > doesn't corrupt its state. > > > > > > > > I.e. this is safe: > > > > > > > > process: interrupt: > > > > old = current->active_memcg > > > > old = current->active_memcg > > > > current->active_memcg = new > > > > allocate > > > > current->active_memcg = old > > > > current->active_memcg = new > > > > return old > > > > > > > > This is safe as well: > > > > > > > > process: interrupt: > > > > old = current->active_memcg > > > > current->active_memcg = new > > > > old = current->active_memcg > > > > current->active_memcg = new > > > > allocate > > > > current->active_memcg = old > > > > return old > > > > > > Yes, you are right. Thanks for the explanation. > > > > Thanks, all. > > > > Dan, I dropped the three-patch series > > > > loop-use-worker-per-cgroup-instead-of-kworker.patch > > mm-charge-active-memcg-when-no-mm-is-set.patch > > loop-charge-i-o-to-mem-and-blk-cg.patch > > > > When convenient, could you please prepend Johannes' patch to the > > series, retest and resend? While doing so, please figure out why you > > didn't also see this warning in your testing and make the appropriate > > changes! > > > > Hi Dan, did you get the chance to follow up on Andrew's request? > > Shakeel Just sent out a new patch series