From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF2E3C38A30 for ; Tue, 21 Apr 2020 02:49:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 740AC20782 for ; Tue, 21 Apr 2020 02:49:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 740AC20782 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 137AF8E0005; Mon, 20 Apr 2020 22:49:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E91B8E0003; Mon, 20 Apr 2020 22:49:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3FD28E0005; Mon, 20 Apr 2020 22:49:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id DA3538E0003 for ; Mon, 20 Apr 2020 22:49:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9B3CF3489 for ; Tue, 21 Apr 2020 02:49:51 +0000 (UTC) X-FDA: 76730332182.04.talk33_387fd1c06974f X-HE-Tag: talk33_387fd1c06974f X-Filterd-Recvd-Size: 1607 Received: from r3-19.sinamail.sina.com.cn (r3-19.sinamail.sina.com.cn [202.108.3.19]) by imf09.hostedemail.com (Postfix) with SMTP for ; Tue, 21 Apr 2020 02:49:44 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.253.228.166]) by sina.com with ESMTP id 5E9E5F170000DEFE; Tue, 21 Apr 2020 10:48:56 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 51771115074536 From: Hillf Danton To: Dan Schatzberg Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/4] loop: Use worker per cgroup instead of kworker Date: Tue, 21 Apr 2020 10:48:45 +0800 Message-Id: <20200421024845.6948-1-hdanton@sina.com> In-Reply-To: <20200420223936.6773-1-schatzberg.dan@gmail.com> References: <20200420223936.6773-1-schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 20 Apr 2020 18:39:29 -0400 Dan Schatzberg wrote: >=20 > @@ -1140,8 +1215,17 @@ static int __loop_clr_fd(struct loop_device *lo,= bool release) > blk_mq_freeze_queue(lo->lo_queue); > =20 > spin_lock_irq(&lo->lo_lock); > + destroy_workqueue(lo->workqueue); Destruct it out of atomic context. > lo->lo_backing_file =3D NULL; > + list_for_each_entry_safe(worker, pos, &lo->idle_worker_list, > + idle_list) { > + list_del(&worker->idle_list); > + rb_erase(&worker->rb_node, &lo->worker_tree); > + css_put(worker->css); > + kfree(worker); > + } > spin_unlock_irq(&lo->lo_lock);