From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1962CC54FC9 for ; Tue, 21 Apr 2020 11:19:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3088206D5 for ; Tue, 21 Apr 2020 11:18:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="uPEqZ7eo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3088206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 142F18E0005; Tue, 21 Apr 2020 07:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F3138E0003; Tue, 21 Apr 2020 07:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 007718E0005; Tue, 21 Apr 2020 07:18:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id DA1748E0003 for ; Tue, 21 Apr 2020 07:18:58 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9761B2481 for ; Tue, 21 Apr 2020 11:18:58 +0000 (UTC) X-FDA: 76731615156.01.shop63_8887a06089916 X-HE-Tag: shop63_8887a06089916 X-Filterd-Recvd-Size: 2562 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 11:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zTZk99AiK5OjEAUI30e4RyjGcOqu7o/1DlNaNqdP1sM=; b=uPEqZ7eoM9Nf+ex2VARi90OFMI BlgWj8s1VbeYfOJ5p6Cp7KjPB40VZvnmVQLet+CiB8Nd85t93MQto0tWtFqjJSdnVtcgBWvo/0syV cW62zgfDK1qOJ1cgJMsqmI0c3pup4O4wOEHKA2XM+fClfAaopNFuK37futYMRraFTtcRYUSZqBSYW zrFsPcgYUP5FNgGqooNzKEy5VK4ZyQOVubtQf0Y5y5mzMDLoBcjLeOz2K4cpCJx4RWqbAPG+4Td84 ScZCQsQJk3CFQBKeXOg/2aF/d+gcP0Oy0PQ92biA8OJ3TGbPzi/4Tmbglq2hkdqFOW0bR5EtiKs8K JsChop9Q==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQqvR-00034i-FN; Tue, 21 Apr 2020 11:18:49 +0000 Date: Tue, 21 Apr 2020 04:18:49 -0700 From: Matthew Wilcox To: 1587089010-110083-1-git-send-email-bernard@vivo.com Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, Bernard Zhao Subject: Re: [PATCH V2] kmalloc_index optimization(code size & runtime stable) Message-ID: <20200421111849.GL5820@bombadil.infradead.org> References: <20200421032501.127370-1-bernard@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421032501.127370-1-bernard@vivo.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 20, 2020 at 08:25:01PM -0700, Bernard Zhao wrote: > kmalloc_index inline function code size optimization and runtime > performance stability optimization. After optimization, the function > kmalloc_index is more stable, the size will never affecte the function`s > execution efficiency. Please stop posting this patch until it's faster *for small sizes*. As I explained last time you posted it, it's not an optimisation. > size time/Per 100 million times > old fun new fun with optimise > 8 203777 241934 > 16 245611 409278 > 32 236384 408419 > 64 275499 447732 > 128 354909 416439 ^^^^ these are the important cases that need to be fast.