From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736B9C54FC9 for ; Tue, 21 Apr 2020 12:39:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3CB7A2074F for ; Tue, 21 Apr 2020 12:39:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CB7A2074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD6B48E0009; Tue, 21 Apr 2020 08:39:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5ECC8E0003; Tue, 21 Apr 2020 08:39:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C26C28E0009; Tue, 21 Apr 2020 08:39:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id A75918E0003 for ; Tue, 21 Apr 2020 08:39:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6C8AE181AEF1F for ; Tue, 21 Apr 2020 12:39:56 +0000 (UTC) X-FDA: 76731819192.01.wren70_73d9813256058 X-HE-Tag: wren70_73d9813256058 X-Filterd-Recvd-Size: 5469 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 12:39:55 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id g12so3498936wmh.3 for ; Tue, 21 Apr 2020 05:39:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AuPLFkimWuCWGUf4RTGB0fzJ4keg1cVbd+1olbT2/Z8=; b=n/gFGKMmCTgedTAuoH/pn4zXl/nDE3ZUHk/Ccy3F6DdJCgSK6bfpyMmhHeDzuVAcqF XQxg6KxNhcgzFh4BQHTcLKiV5T/XoGhvoqoTA6l21lfc0BrV2hHVRwIMtI1IB3eJ4qNB VuzO14n3QxeSZZ6Dp6JwBZc/WXmm9BqGeDRevtkEG/M2H3vxXtnWfrKuI6Jm8EL+rUL8 chE+V9bQVGi/562v8NQWYRlgOPm5xnHsoRGK+4UzALqmCLQvGi6ACLtgnmzxLzlYrisC YE4Qq1isIIMgGeOg2hj+vDIkl0A3UnTqNPCiGMRRACxsbukANj1j5Xu0DrBB/a73FrbX Onwg== X-Gm-Message-State: AGi0PuYhOvV+P9tzksTdUSZVXwvI2e+rEuS8No1DkLiwuU0T/uvg6YOH F9K/cc3G/plpupUOI5lfM3o= X-Google-Smtp-Source: APiQypI/CyQCAErgAxIZZX5m7BAQjn7WjN3SwqKqvewCm1OVxVlfTYE5d6yPmGJodNZr+y0h7QoV4Q== X-Received: by 2002:a05:600c:2316:: with SMTP id 22mr4607519wmo.164.1587472795013; Tue, 21 Apr 2020 05:39:55 -0700 (PDT) Received: from localhost (ip-37-188-130-62.eurotel.cz. [37.188.130.62]) by smtp.gmail.com with ESMTPSA id l19sm3409777wmj.14.2020.04.21.05.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2020 05:39:53 -0700 (PDT) Date: Tue, 21 Apr 2020 14:39:53 +0200 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Baoquan He , Oscar Salvador , Pankaj Gupta , Mike Rapoport , Anshuman Khandual Subject: Re: [PATCH RFC 2/2] mm/memory_hotplug: handle memblocks only with CONFIG_ARCH_KEEP_MEMBLOCK Message-ID: <20200421123953.GF27314@dhcp22.suse.cz> References: <20200416104707.20219-1-david@redhat.com> <20200416104707.20219-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416104707.20219-3-david@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 16-04-20 12:47:07, David Hildenbrand wrote: > The comment in add_memory_resource() is stale: hotadd_new_pgdat() will > no longer call get_pfn_range_for_nid(), as a hotadded pgdat will simply > span no pages at all, until memory is moved to the zone/node via > move_pfn_range_to_zone() - e.g., when onlining memory blocks. > > The only archs that care about memblocks for hotplugged memory (either > for iterating over all system RAM or testing for memory validity) are > arm64, s390x, and powerpc - due to CONFIG_ARCH_KEEP_MEMBLOCK. Without > CONFIG_ARCH_KEEP_MEMBLOCK, we can simply stop messing with memblocks. OK, makes sense to me. > For s390x, it seems to be fairly easy to avoid CONFIG_ARCH_KEEP_MEMBLOCK. > arm64 could rework most code (esp., pfn_valid(), valid_phys_addr_range() > and kexec_file_load()) to not require memblocks for hotplugged > memory. E.g., as hotplugged memory has no holes and can be identified > using !early_section(), arm64's variant of pfn_valid() could be reworked > fairly easily to not require memblocks for hotadded memory. powerpc might > be more involed. I haven't checked these architectures but is the information really useful for this patch? > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Baoquan He > Cc: Oscar Salvador > Cc: Pankaj Gupta > Cc: Mike Rapoport > Cc: Anshuman Khandual > Signed-off-by: David Hildenbrand Acked-by: Michal Hocko with a minor nit > - /* > - * Add new range to memblock so that when hotadd_new_pgdat() is called > - * to allocate new pgdat, get_pfn_range_for_nid() will be able to find > - * this new range and calculate total pages correctly. The range will > - * be removed at hot-remove time. > - */ > +#ifdef CONFIG_ARCH_KEEP_MEMBLOCK if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK) would be slightly nicer. This should work for all the ifedefs in this patch. > memblock_add_node(start, size, nid); > +#endif > > ret = __try_online_node(nid, false); > if (ret < 0) > @@ -1075,7 +1071,9 @@ int __ref add_memory_resource(int nid, struct resource *res) > /* rollback pgdat allocation and others */ > if (new_node) > rollback_node_hotadd(nid); > +#ifdef CONFIG_ARCH_KEEP_MEMBLOCK > memblock_remove(start, size); > +#endif > mem_hotplug_done(); > return ret; > } > @@ -1751,8 +1749,11 @@ static int __ref try_remove_memory(int nid, u64 start, u64 size) > mem_hotplug_begin(); > > arch_remove_memory(nid, start, size, NULL); > + > +#ifdef CONFIG_ARCH_KEEP_MEMBLOCK > memblock_free(start, size); > memblock_remove(start, size); > +#endif > __release_memory_resource(start, size); > > try_offline_node(nid); > -- > 2.25.1 -- Michal Hocko SUSE Labs