From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F0DC54FD0 for ; Tue, 21 Apr 2020 13:57:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5CF61206D9 for ; Tue, 21 Apr 2020 13:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o5rA5yj7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CF61206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0CD858E0008; Tue, 21 Apr 2020 09:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07BFF8E0003; Tue, 21 Apr 2020 09:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFA108E0008; Tue, 21 Apr 2020 09:57:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id D72228E0003 for ; Tue, 21 Apr 2020 09:57:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A28E24427 for ; Tue, 21 Apr 2020 13:57:36 +0000 (UTC) X-FDA: 76732014912.25.drop98_42642d5637b12 X-HE-Tag: drop98_42642d5637b12 X-Filterd-Recvd-Size: 3665 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 13:57:36 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id t8so4575052qvw.5 for ; Tue, 21 Apr 2020 06:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=g8sI+x0ifL/wEFiFPpalnoznOyEqF0zjwgw2NNC+4mc=; b=o5rA5yj7PKRli/WEwKCwKAqzHohjrHFYqnF5aOaJyw7loMnWOIWACm2qTaSQs7LUeI 5gJoRqg2exMdQBKvkbyb2/gjHBNwLUb1gI6cbPr9FPPCCZBV4xAiPE5fBow5c+GAaY8N KJSh53mCr0DMHmQ0EnIfAumN9vKJBzmcGvG8pcrHUYcicJq5SqyOUCrF5pPcjmn4Lptl MlEccAm4LT2dppQdo51o7NJm5XasujoL4CaGuCnwL5QWCFLeuhAtEpR4eMlTrkLSEuJI LdoHtDXqd58r51j+H6Eq6OUEHMl4hy/V8Qicr4E+5BxnYC+0lzKwrpFU5f6+m+YSN+iA QHcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g8sI+x0ifL/wEFiFPpalnoznOyEqF0zjwgw2NNC+4mc=; b=gbUNb/+VZYq4gH82KKlov2cHLGxRvimIYe3SDg8ily5rYoWXTB9nz9E9+PhkQpa13q XBYz7W2TNU+JHmhNMhMqtUoNLlrTENu8hcn355A092NVyz/z2cBroqSKQr0WLpZMFSnt ofE2CBkx/f3ju3ntTr1UBYbdD9Jd/h7bRxts/h0jr7PCBeJFa2sa+rJJuFr/1vT7lkmx fCxq1UDTC0w3TKX0s0rj5+gIOUR+EsDacA+MfH24YpL0ueXvrQhOrDSI7Oe8UobNC9LK e3loX2Q8rtiNZANeGu2e1oDUrE/aq6+qFEIwMoPDYPDPH1VulgvveadOALX2UmkpW9k2 cLyA== X-Gm-Message-State: AGi0PubGQi7NxfKMtyyycKwuNXoBSd8ywth+y/m968OBhilZ8j6BM9cf GG0K74BoYwZL3n8PxTmsDYY= X-Google-Smtp-Source: APiQypK7FnDixMI3pzcl99s2hbVp+PWT8UxbdsNbkRGLe4Q3ASFN5r2ywfFxMVJjC/xKVGDD5F+B0w== X-Received: by 2002:a05:6214:28d:: with SMTP id l13mr19522391qvv.181.1587477455411; Tue, 21 Apr 2020 06:57:35 -0700 (PDT) Received: from dschatzberg-fedora-PC0Y6AEN ([2620:10d:c091:480::1:6809]) by smtp.gmail.com with ESMTPSA id t67sm1785469qka.17.2020.04.21.06.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2020 06:57:34 -0700 (PDT) Date: Tue, 21 Apr 2020 09:57:32 -0400 From: Dan Schatzberg To: Hillf Danton Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/4] loop: Charge i/o to mem and blk cg Message-ID: <20200421135732.GB9623@dschatzberg-fedora-PC0Y6AEN> References: <20200420223936.6773-1-schatzberg.dan@gmail.com> <20200421033337.13208-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421033337.13208-1-hdanton@sina.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.021474, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 21, 2020 at 11:33:37AM +0800, Hillf Danton wrote: > > On Mon, 20 Apr 2020 18:39:32 -0400 Dan Schatzberg wrote: > > > > @@ -964,13 +960,16 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd) > > worker = kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOWARN); > > /* > > * In the event we cannot allocate a worker, just queue on the > > - * rootcg worker > > + * rootcg worker and issue the I/O as the rootcg > > */ > > - if (!worker) > > + if (!worker) { > > + cmd->blkcg_css = NULL; > > + cmd->memcg_css = NULL; > > Dunno if css_put(cmd->memcg_css); Good catch. Need to drop the reference here.