From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51923C54FC9 for ; Tue, 21 Apr 2020 15:43:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9224206F4 for ; Tue, 21 Apr 2020 15:43:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="S2Ei/2rA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9224206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 50D7E8E0005; Tue, 21 Apr 2020 11:43:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4968A8E0003; Tue, 21 Apr 2020 11:43:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35E968E0005; Tue, 21 Apr 2020 11:43:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 1BE5A8E0003 for ; Tue, 21 Apr 2020 11:43:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B91E74857 for ; Tue, 21 Apr 2020 15:43:52 +0000 (UTC) X-FDA: 76732282704.06.dolls38_791fcc8f04c18 X-HE-Tag: dolls38_791fcc8f04c18 X-Filterd-Recvd-Size: 4740 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 15:43:52 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03LFYLpu158456; Tue, 21 Apr 2020 15:43:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=eOpQsTy+r52WApbn5F48tilahuPcKCpRcdAW8A4UlGA=; b=S2Ei/2rA/w6p0BxCFzMel9pG0tGXIyv5DeGr5XvUhFbU/FjplPPc6aqDy4JxcbEku14D Ve4KWY5YmbeBuXRXCsbf7lWvIDxvAxl5bn20O+GNaQ32NHoyZHCqMQSHMKcRBb10fCGM o/51uH2YV97a00SwX+fh06iFH6xzm0JyHmkZcBNw44/EwVbYwCA7g+aAK9IOk0hCuZIl 1TMs2+mIycw+CdB0kyCDrT5jTqCO4edVKXuYma4P0FKbRvw+UO0hPGFNIPhOCTvXX/Ob XRbS6J5OBxfcOj96IpHq8uQPVw8U98ESv9zgk42yaYDfgyZ0UU5Cyh2ro1iggUA/fBsM Dw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 30grpgj7g9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Apr 2020 15:43:42 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03LFbbiG157058; Tue, 21 Apr 2020 15:43:42 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 30gb90aye7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Apr 2020 15:43:42 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 03LFhcFu029521; Tue, 21 Apr 2020 15:43:38 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 21 Apr 2020 08:43:37 -0700 Date: Tue, 21 Apr 2020 08:43:33 -0700 From: "Darrick J. Wong" To: Domenico Andreoli Cc: "Rafael J. Wysocki" , Linux PM , Linux Memory Management List , linux-fsdevel@vger.kernel.org, mkleinsoft@gmail.com, Christoph Hellwig , Andrew Morton , "Rafael J. Wysocki" , Len Brown , Pavel Machek Subject: Re: [PATCH] hibernate: unlock swap bdev for writing when uswsusp is active Message-ID: <20200421154333.GG6749@magnolia> References: <20200229170825.GX8045@magnolia> <20200229180716.GA31323@dumbo> <20200229183820.GA8037@magnolia> <20200229200200.GA10970@dumbo> <20200420185255.GA20916@dumbo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420185255.GA20916@dumbo> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9598 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004210121 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9598 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1011 malwarescore=0 phishscore=0 spamscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004210121 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 20, 2020 at 08:52:55PM +0200, Domenico Andreoli wrote: > On Sun, Mar 01, 2020 at 10:35:36PM +0100, Rafael J. Wysocki wrote: > > On Sat, Feb 29, 2020 at 9:02 PM Domenico Andreoli wrote: > > > > > > Maybe user-space hibernation should be a separate option. > > > > That actually is not a bad idea at all in my view. > > I prepared a patch for this: > https://lore.kernel.org/linux-pm/20200413190843.044112674@gmail.com/ If you succeed in making uswsusp a kconfig option, can you amend the "!hibernation available()" test in blkdev_write_iter so that users of in-kernel hibernate are protected against userspace swap device scribbles, please? --D > Regards, > Domenico > > -- > rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13 > ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05