linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>, Linux MM <linux-mm@kvack.org>,
	Shakeel Butt <shakeelb@google.com>
Subject: Re: [PATCH v2] mm, memcg: fix inconsistent oom event behavior
Date: Wed, 22 Apr 2020 14:02:14 +0100	[thread overview]
Message-ID: <20200422130214.GA949935@chrisdown.name> (raw)
In-Reply-To: <CALOAHbBba+7CHsDpnmnQfQqrK-5qkgvnd8+O72wbQAQDi73caw@mail.gmail.com>

Yafang Shao writes:
>That is what I did in the previous version, see also
>https://lore.kernel.org/linux-mm/20200414015952.3590-1-laoar.shao@gmail.com/

Your v1 patch was significantly less complicated and self-contained, and I 
would ack it (whereas I wouldn't ack this because it really complicates matters 
for localevents). My only questions were around quantifying the issue in the 
changelog :-)


  reply	other threads:[~2020-04-22 13:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 11:06 [PATCH v2] mm, memcg: fix inconsistent oom event behavior Yafang Shao
2020-04-22 11:51 ` Michal Hocko
2020-04-22 12:54 ` Johannes Weiner
2020-04-22 12:58   ` Yafang Shao
2020-04-22 13:02     ` Chris Down [this message]
2020-04-22 13:15       ` Yafang Shao
2020-04-22 13:15   ` Michal Hocko
  -- strict thread matches above, loose matches on Subject: below --
2020-04-14  1:59 Yafang Shao
2020-04-14 15:22 ` Michal Hocko
2020-04-14 15:57   ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422130214.GA949935@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).