From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ABB5C55185 for ; Wed, 22 Apr 2020 17:22:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 752CC20776 for ; Wed, 22 Apr 2020 17:22:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 752CC20776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1285A8E000A; Wed, 22 Apr 2020 13:22:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D9738E0003; Wed, 22 Apr 2020 13:22:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 015F08E000A; Wed, 22 Apr 2020 13:22:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id DE9888E0003 for ; Wed, 22 Apr 2020 13:22:58 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9130A181AEF00 for ; Wed, 22 Apr 2020 17:22:58 +0000 (UTC) X-FDA: 76736161236.09.nut52_19ed1886c2b62 X-HE-Tag: nut52_19ed1886c2b62 X-Filterd-Recvd-Size: 1688 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 17:22:57 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7BAAA68C4E; Wed, 22 Apr 2020 19:22:54 +0200 (CEST) Date: Wed, 22 Apr 2020 19:22:54 +0200 From: Christoph Hellwig To: Andrey Ignatov Cc: Christoph Hellwig , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 5/5] sysctl: pass kernel pointers to ->proc_handler Message-ID: <20200422172254.GA30102@lst.de> References: <20200421171539.288622-1-hch@lst.de> <20200421171539.288622-6-hch@lst.de> <20200421192330.GA60879@rdna-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421192330.GA60879@rdna-mbp.dhcp.thefacebook.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 21, 2020 at 12:23:30PM -0700, Andrey Ignatov wrote: > > if (ret == 1 && ctx.new_updated) { > > - *new_buf = ctx.new_val; > > + *buf = ctx.new_val; > > Original value of *buf should be freed before overriding it here > otherwise it's lost/leaked unless I missed something. > > Other than this BPF part of this patch looks good to me. Feel free to > add my Ack on the next iteration with this fix. Thanks, fixed. Can you also comment on "bpf-cgroup: remove unused exports" ?