From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 386D6C55185 for ; Wed, 22 Apr 2020 17:26:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1511F20776 for ; Wed, 22 Apr 2020 17:26:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1511F20776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B5E608E000A; Wed, 22 Apr 2020 13:26:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F228E0003; Wed, 22 Apr 2020 13:26:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4B608E000A; Wed, 22 Apr 2020 13:26:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 8E5998E0003 for ; Wed, 22 Apr 2020 13:26:55 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 47162181AEF00 for ; Wed, 22 Apr 2020 17:26:55 +0000 (UTC) X-FDA: 76736171190.04.tail91_3c5d58897492f X-HE-Tag: tail91_3c5d58897492f X-Filterd-Recvd-Size: 1718 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 17:26:54 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id BEBBD68C4E; Wed, 22 Apr 2020 19:26:51 +0200 (CEST) Date: Wed, 22 Apr 2020 19:26:51 +0200 From: Christoph Hellwig To: "Eric W. Biederman" Cc: Christoph Hellwig , Kees Cook , Iurii Zaikin , Luis Chamberlain , Greg Kroah-Hartman , "Rafael J. Wysocki" , Alexei Starovoitov , Daniel Borkmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 4/6] sysctl: remove all extern declaration from sysctl.c Message-ID: <20200422172651.GC30102@lst.de> References: <20200417064146.1086644-1-hch@lst.de> <20200417064146.1086644-5-hch@lst.de> <87d07z4s54.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d07z4s54.fsf@x220.int.ebiederm.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 22, 2020 at 07:33:11AM -0500, Eric W. Biederman wrote: > > +extern int core_uses_pid; > > +extern char core_pattern[]; > > +extern unsigned int core_pipe_limit; > > +extern int pid_max; > > +extern int pid_max_min, pid_max_max; > > These last two pid_max, pid_max_mind and pid_max_max would make more > sense in pid.h as they have nothing to do with coredumps. Done for the next version.