From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F09C5518A for ; Wed, 22 Apr 2020 11:18:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 056E420781 for ; Wed, 22 Apr 2020 11:18:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 056E420781 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 966D28E000E; Wed, 22 Apr 2020 07:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 917838E0003; Wed, 22 Apr 2020 07:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82E378E000E; Wed, 22 Apr 2020 07:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id 6B40F8E0003 for ; Wed, 22 Apr 2020 07:18:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 344E48248047 for ; Wed, 22 Apr 2020 11:18:21 +0000 (UTC) X-FDA: 76735242402.16.gold13_2bb7978cb790e X-HE-Tag: gold13_2bb7978cb790e X-Filterd-Recvd-Size: 7125 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 11:18:20 +0000 (UTC) IronPort-SDR: rOkrazmKR4l9JYIAqaIuELiO5DtsR8eRVFr3ENS4bUsXPEI2TMZIdNgJx35J6WcGa0FnEbHcBn x+2MRYH6TSCg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 04:18:18 -0700 IronPort-SDR: yjDUmLnrAp3nPM++rWGbhbiP+fk2ZZXzCpYbitG0voHooB4HcwejvvPP1Xn+E70WMzCRqlrpwA VCXcjkYUFh6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,414,1580803200"; d="scan'208";a="290800598" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 22 Apr 2020 04:18:14 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1jRDOP-0004yW-Jf; Wed, 22 Apr 2020 19:18:13 +0800 Date: Wed, 22 Apr 2020 19:17:34 +0800 From: kbuild test robot To: Scott Branden , Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Arnd Bergmann Cc: kbuild-all@lists.01.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Linux Memory Management List , Dan Carpenter Subject: Re: [PATCH v3 6/7] misc: bcm-vk: add Broadcom VK driver Message-ID: <202004221945.LY6x0DQD%lkp@intel.com> References: <20200420162809.17529-7-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420162809.17529-7-scott.branden@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Scott, I love your patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on next-20200421] [cannot apply to char-misc/char-misc-testing kselftest/next linus/master v5.7-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200422-114528 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 55623260bb33e2ab849af76edf2253bc04cb241f reproduce: # apt-get install sparse # sparse version: v0.6.1-191-gc51a0382-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/misc/bcm-vk/bcm_vk_dev.c:189:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct bcm_vk_peer_log *p_ctl @@ got struct bcm_vk_peer_log *p_ctl @@ >> drivers/misc/bcm-vk/bcm_vk_dev.c:189:15: sparse: expected struct bcm_vk_peer_log *p_ctl >> drivers/misc/bcm-vk/bcm_vk_dev.c:189:15: sparse: got void [noderef] * >> drivers/misc/bcm-vk/bcm_vk_dev.c:685:36: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] *from @@ got oderef] *from @@ >> drivers/misc/bcm-vk/bcm_vk_dev.c:685:36: sparse: expected void const [noderef] *from >> drivers/misc/bcm-vk/bcm_vk_dev.c:685:36: sparse: got struct vk_image *arg drivers/misc/bcm-vk/bcm_vk_dev.c:780:36: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] *from @@ got oderef] *from @@ drivers/misc/bcm-vk/bcm_vk_dev.c:780:36: sparse: expected void const [noderef] *from >> drivers/misc/bcm-vk/bcm_vk_dev.c:780:36: sparse: got struct vk_reset *arg >> drivers/misc/bcm-vk/bcm_vk_dev.c:858:45: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct vk_image *arg @@ got void [nstruct vk_image *arg @@ >> drivers/misc/bcm-vk/bcm_vk_dev.c:858:45: sparse: expected struct vk_image *arg >> drivers/misc/bcm-vk/bcm_vk_dev.c:858:45: sparse: got void [noderef] *argp >> drivers/misc/bcm-vk/bcm_vk_dev.c:862:40: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct vk_reset *arg @@ got void [nstruct vk_reset *arg @@ >> drivers/misc/bcm-vk/bcm_vk_dev.c:862:40: sparse: expected struct vk_reset *arg drivers/misc/bcm-vk/bcm_vk_dev.c:862:40: sparse: got void [noderef] *argp -- >> drivers/misc/bcm-vk/bcm_vk_msg.c:507:17: sparse: sparse: cast removes address space '' of expression drivers/misc/bcm-vk/bcm_vk_msg.c:707:15: sparse: sparse: cast removes address space '' of expression drivers/misc/bcm-vk/bcm_vk_msg.c:715:23: sparse: sparse: cast removes address space '' of expression drivers/misc/bcm-vk/bcm_vk_msg.c:871:31: sparse: sparse: cast removes address space '' of expression drivers/misc/bcm-vk/bcm_vk_msg.c:899:47: sparse: sparse: cast removes address space '' of expression vim +189 drivers/misc/bcm-vk/bcm_vk_dev.c 180 181 static void bcm_vk_dump_peer_log(struct bcm_vk *vk) 182 { 183 struct bcm_vk_peer_log log, *p_ctl; 184 char loc_buf[BCM_VK_PEER_LOG_LINE_MAX]; 185 int cnt; 186 struct device *dev = &vk->pdev->dev; 187 uint data_offset; 188 > 189 p_ctl = vk->bar[BAR_2] + vk->peerlog_off; 190 log = *p_ctl; 191 /* do a rmb() to make sure log is updated */ 192 rmb(); 193 194 dev_dbg(dev, "Peer PANIC: Size 0x%x(0x%x), [Rd Wr] = [%d %d]\n", 195 log.buf_size, log.mask, log.rd_idx, log.wr_idx); 196 197 cnt = 0; 198 data_offset = vk->peerlog_off + sizeof(struct bcm_vk_peer_log); 199 while (log.rd_idx != log.wr_idx) { 200 loc_buf[cnt] = vkread8(vk, BAR_2, data_offset + log.rd_idx); 201 202 if ((loc_buf[cnt] == '\0') || 203 (cnt == (BCM_VK_PEER_LOG_LINE_MAX - 1))) { 204 dev_err(dev, "%s", loc_buf); 205 cnt = 0; 206 } else { 207 cnt++; 208 } 209 log.rd_idx = (log.rd_idx + 1) & log.mask; 210 } 211 /* update rd idx at the end */ 212 vkwrite32(vk, log.rd_idx, BAR_2, vk->peerlog_off); 213 } 214 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org