From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80523C54FCB for ; Thu, 23 Apr 2020 14:06:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49CCC2077D for ; Thu, 23 Apr 2020 14:06:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49CCC2077D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC2AD8E0005; Thu, 23 Apr 2020 10:06:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4BF78E0003; Thu, 23 Apr 2020 10:06:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D14388E0005; Thu, 23 Apr 2020 10:06:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id B3F6C8E0003 for ; Thu, 23 Apr 2020 10:06:50 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7B991180AD81A for ; Thu, 23 Apr 2020 14:06:50 +0000 (UTC) X-FDA: 76739295780.26.glue61_75dfff729ed53 X-HE-Tag: glue61_75dfff729ed53 X-Filterd-Recvd-Size: 3405 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Apr 2020 14:06:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2D70EACF0; Thu, 23 Apr 2020 14:06:47 +0000 (UTC) Date: Thu, 23 Apr 2020 16:06:46 +0200 From: Michal Hocko To: Tetsuo Handa Cc: Yafang Shao , Andrew Morton , Roman Gushchin , linux-mm , David Rientjes , Shakeel Butt , Sergey Senozhatsky , Petr Mladek , Steven Rostedt Subject: Re: [nacked] mm-oom-avoid-printk-iteration-under-rcu.patch removed from -mm tree Message-ID: <20200423140646.GF4206@dhcp22.suse.cz> References: <68371d79-dfae-e9b9-38df-dbb916607a82@i-love.sakura.ne.jp> <20200420073305.GD27314@dhcp22.suse.cz> <041d4158-f3dc-a5b5-546e-dd3f71f67b5f@i-love.sakura.ne.jp> <20200422065950.GA30312@dhcp22.suse.cz> <0aa5e490-c5b8-dc5c-334e-9a8d37da215c@i-love.sakura.ne.jp> <20200423073438.GC4206@dhcp22.suse.cz> <20200423110707.GD4206@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 23-04-20 22:28:00, Tetsuo Handa wrote: > On 2020/04/23 20:07, Michal Hocko wrote: > > The existing loglevels we use are not really carved in stone and we can > > prioritize some more than others. dump_tasks is KERN_INFO already and > > this is quite a low priority so you shouldn't really miss much when > > omitting it. But I wouldn't mind making it KERN_DEBUG. > > Do you mean > > - pr_info("[%7d] %5d %5d %8lu %8lu %8ld %8lu %5hd %s\n", > + pr_debug("[%7d] %5d %5d %8lu %8lu %8ld %8lu %5hd %s\n", > > in order to suppress printing to consoles? Not with the primary intention. But reducing the log level might allow to filter it more easily because KERN_DEBUG should really be something that can be dropped on the floor. I am not aware of heavy KERN_INFO users that would matter so the current log level makes sense to me but maybe there are some and that's why I've mentioned I wouldn't be opposed. [...] > Last year I proposed > https://lkml.kernel.org/r/1550896930-12324-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp > and Sergey Senozhatsky commented > > "This is a bit of a strange issue, to be honest. If OOM prints too > many messages then we might want to do some work on the OOM side." > > . I was thinking that printing to consoles is a requirement for oom_dump_tasks . > > If we can agree with not printing dump_tasks() output to consoles, a trivial > patch shown below will solve the problem. Those who cannot run syslog daemon > in userspace might disagree, but this will be the simplest answer. Talk to printk people about this. -- Michal Hocko SUSE Labs