From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CABB7C55199 for ; Sun, 26 Apr 2020 15:51:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B57D2074F for ; Sun, 26 Apr 2020 15:51:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sDZrN2+0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B57D2074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B91158E0005; Sun, 26 Apr 2020 11:51:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1A468E0001; Sun, 26 Apr 2020 11:51:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A08AA8E0005; Sun, 26 Apr 2020 11:51:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 856178E0001 for ; Sun, 26 Apr 2020 11:51:05 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4141F501F for ; Sun, 26 Apr 2020 15:51:05 +0000 (UTC) X-FDA: 76750444890.20.boats90_268f65d3b1606 X-HE-Tag: boats90_268f65d3b1606 X-Filterd-Recvd-Size: 3745 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Sun, 26 Apr 2020 15:51:04 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id t16so5904330plo.7 for ; Sun, 26 Apr 2020 08:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0tREdJmgxZBE3LuxNv5lLUb9+sRKgXBjmxyZW6AGnrE=; b=sDZrN2+0H3oWhbgC3FN3dRrI+vnpl/bE9yHq8HRC57KvZN2rYMU2YRLxV5qkKH1pVy 2CEb2u+YbK6heFjgQNutKPxZDTi5bZft3ysYJscFcqPkt8EWoFfFqhuyhD0IhGc8xijs 6wBlKoRXKVlSpCr6KqKzheomL5/Rk8Uw0UScYFq1VovEbNlisshNYBWu+C6YDqSBequT Nf1a7uOegzBkQrYV5IEgEwdyvM4q9w7PHzBJ0CpZzGPF6MdO/lGw3QUREHszldPK3GpU 3qL0nrO8xVS4zdE/prR/cCJxxB3lAoKG3awGlwXr7pm9T42nRAtkMY+zlPZstgEgzkuG OVZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0tREdJmgxZBE3LuxNv5lLUb9+sRKgXBjmxyZW6AGnrE=; b=akMYQHgfPP5Rmojvntd6GKeJvonbSVyf27aTYwFrJC45rkUUM2QA94v07MzSX4iplB IVKOAtxDkAFXBIhRo6JlvTo5hs4yspFlv3OfFOBiJs4dqSb0FgBrvoBePsjFGTRu5WYd Rq0rRbBSXmydlE5gA6p6gpxkwqcVFEWM9AR2PblUUAWnvglZjvcNvNHuJ0ZAan25T+zP kLXGBKDCS4NWddBqA8QDdSrww+pxFx3xHPbnrI2ZwJ3n2Ot1KwERgfBVItJ5ihqJv/pG hUHBfiJUqL2B4eAL5PTMfp1nwYzT1SIqcBMmw+sTemZU/C+GfFuV6xqGoItpHST5RqLV fGBA== X-Gm-Message-State: AGi0PuaJ+fww5+T+9dr6UfIOCEFnyvlPMjQbR9EEpzG5sYhmxLZeMwiG XicNFoJFF+X8cigV8GqzCJA= X-Google-Smtp-Source: APiQypK/TQCrX63vJaNJa+pMMCMrbYitizNxouXhoQm6uhpCCnnkEGp/tWQ1QRiNM4UdLfeHiDtWOw== X-Received: by 2002:a17:90a:23cd:: with SMTP id g71mr17811667pje.174.1587916263895; Sun, 26 Apr 2020 08:51:03 -0700 (PDT) Received: from ast-mbp ([2620:10d:c090:400::5:9db4]) by smtp.gmail.com with ESMTPSA id j5sm1088560pfh.58.2020.04.26.08.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2020 08:51:02 -0700 (PDT) Date: Sun, 26 Apr 2020 08:51:00 -0700 From: Alexei Starovoitov To: Christoph Hellwig Cc: Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: pass kernel pointers to the sysctl ->proc_handler method v3 Message-ID: <20200426155100.bcbqnrilk45ugzva@ast-mbp> References: <20200424064338.538313-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200424064338.538313-1-hch@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 24, 2020 at 08:43:33AM +0200, Christoph Hellwig wrote: > Hi all, > > this series changes the sysctl ->proc_handler methods to take kernel > pointers. This simplifies some of the pointer handling in the methods > (which could probably be further simplified now), and gets rid of the > set_fs address space overrides used by bpf. > > Changes since v2: > - free the buffer modified by BPF > - move pid_max and friends to pid.h > > Changes since v1: > - drop a patch merged by Greg > - don't copy data out on a write > - fix buffer allocation in bpf The set looks good to me. Should I take it via bpf-next tree ?