From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B345C83003 for ; Wed, 29 Apr 2020 08:43:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E09820731 for ; Wed, 29 Apr 2020 08:43:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BziO2Ew9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E09820731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 951768E0005; Wed, 29 Apr 2020 04:43:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DD3F8E0001; Wed, 29 Apr 2020 04:43:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77C688E0005; Wed, 29 Apr 2020 04:43:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 5AC598E0001 for ; Wed, 29 Apr 2020 04:43:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1B9275825 for ; Wed, 29 Apr 2020 08:43:34 +0000 (UTC) X-FDA: 76760253948.24.joke99_766912ee9875f X-HE-Tag: joke99_766912ee9875f X-Filterd-Recvd-Size: 7858 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 08:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588149813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YXfFItH5P18wimKPehlOgInV4IZagmY7TFY5qS6jZDs=; b=BziO2Ew9EHl2we5PoJYlkXmRN/Kp9CEnyMdKyBQoCf8V67hrRTZfjAZnyxFRPfUtOq4kBF 4fIvQPjd1e1koZ1MtyCKih0tmhXhWjzS6czRicZhIGW72Pf9G3CwvjmiLSrr4jh5//Vw8r RBV/rDOWMNZhIA4DT2DHg+iQUfh+krU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-FFKHZqfIPW6zEFyPZGYHvA-1; Wed, 29 Apr 2020 04:43:21 -0400 X-MC-Unique: FFKHZqfIPW6zEFyPZGYHvA-1 Received: by mail-wm1-f71.google.com with SMTP id w2so921676wmc.3 for ; Wed, 29 Apr 2020 01:43:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=QcZ6PqElQuIY2I5jkNPEa7pluAGzlonQVidKA7ck390=; b=AezyYD5w9qHW3yW459g3vhltCLHtf0YvIBq46L0T2ds/DDGvSNR1szHcoQ9JZHFHMZ gLTKNlXsBwDogKn0h2wP6yPSry0gxrEuW6ak9Nsy5PhklK4BRav1+U/HWl7JR+hsmpiA KXzW+dWFG96nPsG0A6gPn5iQjPd/oMDBHoKmRd1Bs0mzW8Mexgy/Q7EB06T+JilQDela SSpUltkWtyxQLedBP2onr3lRBxk+6UGTh2fpql7QwQHCz/YK8tYCTGFkoSj+WbjwIE1i 3X8yYEQzCOAm58nSO3xsjMiewQ3BQAqMAsm2Y/l9bLMU8qwBqYhks05ZxY+yCGWzZk/0 ZbSg== X-Gm-Message-State: AGi0PuaTun2t2k4lKjG4c6VNRhSa4OnijF8j0NYi3wBSNvIU9hDArwQT ucIvM7QTjSVBoh4sPnnzzNOO+03LVklMMm1sRo0JC5q18JRpLtkMWRv4ps+v0KFo5exnjITUgBV M7lLnxYH/SRI= X-Received: by 2002:a1c:23d4:: with SMTP id j203mr2121787wmj.49.1588149800347; Wed, 29 Apr 2020 01:43:20 -0700 (PDT) X-Google-Smtp-Source: APiQypLcqDVfxUeEvW87fRGWUdN/d4quJBkD2yf6Dic3zqzuiXhubG6tHiMQWsgKcZj9hZwuRxpaoQ== X-Received: by 2002:a1c:23d4:: with SMTP id j203mr2121740wmj.49.1588149799911; Wed, 29 Apr 2020 01:43:19 -0700 (PDT) Received: from localhost ([2001:470:5b39:28:1273:be38:bc73:5c36]) by smtp.gmail.com with ESMTPSA id t20sm6828575wmi.2.2020.04.29.01.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 01:43:19 -0700 (PDT) Date: Wed, 29 Apr 2020 10:43:18 +0200 From: Oleksandr Natalenko To: Minchan Kim Cc: Andrew Morton , Randy Dunlap , broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au Subject: Re: mmotm 2020-04-26-00-15 uploaded (mm/madvise.c) Message-ID: <20200429084318.wh7gjokuk445mr5d@butterfly.localdomain> References: <20200426071602.ZmQ_9C0ql%akpm@linux-foundation.org> <39bcdbb6-cac8-aa3b-c543-041f9c28c730@infradead.org> <20200427135053.a125f84c62e2857e3dcdce4f@linux-foundation.org> <20200427234512.GD163745@google.com> MIME-Version: 1.0 In-Reply-To: <20200427234512.GD163745@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 27, 2020 at 04:45:12PM -0700, Minchan Kim wrote: > Hi Andrew, >=20 > On Mon, Apr 27, 2020 at 01:50:53PM -0700, Andrew Morton wrote: > > On Sun, 26 Apr 2020 15:48:35 -0700 Randy Dunlap = wrote: > >=20 > > > On 4/26/20 10:26 AM, Randy Dunlap wrote: > > > > On 4/26/20 12:16 AM, akpm@linux-foundation.org wrote: > > > >> The mm-of-the-moment snapshot 2020-04-26-00-15 has been uploaded t= o > > > >> > > > >> http://www.ozlabs.org/~akpm/mmotm/ > > > >> > > > >> mmotm-readme.txt says > > > >> > > > >> README for mm-of-the-moment: > > > >> > > > >> http://www.ozlabs.org/~akpm/mmotm/ > > > >> > > > >> This is a snapshot of my -mm patch queue. Uploaded at random hope= fully > > > >> more than once a week. > > > >> > > > >> You will need quilt to apply these patches to the latest Linus rel= ease (5.x > > > >> or 5.x-rcY). The series file is in broken-out.tar.gz and is dupli= cated in > > > >> http://ozlabs.org/~akpm/mmotm/series > > > >> > > > >> The file broken-out.tar.gz contains two datestamp files: .DATE and > > > >> .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-= mm-ss, > > > >> followed by the base kernel version against which this patch serie= s is to > > > >> be applied. > > > >=20 > > > > Hi, > > > > I'm seeing lots of build failures in mm/madvise.c. > > > >=20 > > > > Is Minchin's patch only partially applied or is it just missing som= e pieces? > > > >=20 > > > > a. mm/madvise.c needs to #include > > > >=20 > > > > b. looks like the sys_process_madvise() prototype in > > > > has not been updated: > > > >=20 > > > > In file included from ../mm/madvise.c:11:0: > > > > ../include/linux/syscalls.h:239:18: error: conflicting types for = =E2=80=98sys_process_madvise=E2=80=99 > > > > asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ > > > > ^ > > > > ../include/linux/syscalls.h:225:2: note: in expansion of macro =E2= =80=98__SYSCALL_DEFINEx=E2=80=99 > > > > __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) > > > > ^~~~~~~~~~~~~~~~~ > > > > ../include/linux/syscalls.h:219:36: note: in expansion of macro =E2= =80=98SYSCALL_DEFINEx=E2=80=99 > > > > #define SYSCALL_DEFINE6(name, ...) SYSCALL_DEFINEx(6, _##name, __V= A_ARGS__) > > > > ^~~~~~~~~~~~~~~ > > > > ../mm/madvise.c:1295:1: note: in expansion of macro =E2=80=98SYSCAL= L_DEFINE6=E2=80=99 > > > > SYSCALL_DEFINE6(process_madvise, int, which, pid_t, upid, > > > > ^~~~~~~~~~~~~~~ > > > > In file included from ../mm/madvise.c:11:0: > > > > ../include/linux/syscalls.h:880:17: note: previous declaration of = =E2=80=98sys_process_madvise=E2=80=99 was here > > > > asmlinkage long sys_process_madvise(int which, pid_t pid, unsigned= long start, > > > > ^~~~~~~~~~~~~~~~~~~ > > >=20 > > > I had to add 2 small patches to have clean madvise.c builds: > > >=20 > >=20 > > hm, not sure why these weren't noticed sooner, thanks. > >=20 > > This patchset is looking a bit tired now. > >=20 > > Things to be addressed (might be out of date): > >=20 > > - http://lkml.kernel.org/r/293bcd25-934f-dd57-3314-bbcf00833e51@redhat.= com >=20 > It seems to be not related to process_madvise. >=20 > >=20 > > - http://lkml.kernel.org/r/2a767d50-4034-da8c-c40c-280e0dda910e@suse.cz > > (I did this) >=20 > Thanks! >=20 > >=20 > > - http://lkml.kernel.org/r/20200310222008.GB72963@google.com >=20 > I will send foldable patches to handle comments. >=20 > >=20 > > - issues arising from the review of > > http://lkml.kernel.org/r/20200302193630.68771-8-minchan@kernel.org >=20 > Oleksandr, What's the outcome of this issue? > Do we still need to change based on the comment? >=20 My current understanding is that we do not mess with signals excessively in the given code path. --=20 Best regards, Oleksandr Natalenko (post-factum) Principal Software Maintenance Engineer