From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FDD2C83004 for ; Wed, 29 Apr 2020 12:21:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFBAD21D7A for ; Wed, 29 Apr 2020 12:21:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFBAD21D7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 579678E001D; Wed, 29 Apr 2020 08:21:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 501688E0001; Wed, 29 Apr 2020 08:21:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CA4D8E001D; Wed, 29 Apr 2020 08:21:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 21E428E0001 for ; Wed, 29 Apr 2020 08:21:56 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D69F0181AC9C6 for ; Wed, 29 Apr 2020 12:21:55 +0000 (UTC) X-FDA: 76760804190.06.table89_853791bc05c21 X-HE-Tag: table89_853791bc05c21 X-Filterd-Recvd-Size: 3934 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 12:21:55 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id ms17so691209pjb.0 for ; Wed, 29 Apr 2020 05:21:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8hYyIcFg83pPVTyQcqYDesu3NloqLxLSIbckmr0AwHk=; b=dekfEDVVbGVUd8FGSmDtR8QEG2+5PApBUV9MgYvVMqq3F/wWAXpnZM8h9xn4apE7HY ZDQV1S7iUp4vwzg/5lwmrsFWIwIORxt4kJ+IS7o7XsG55PzyjBLU5vjLPMeetVpktZPN 4WWGaOE6YVJOS0G6sufnbz2C6F+7vWiq52e3frjmBCkbS/k+BkFIlU84HAv4rJwfNub/ 3jfFQA6s5JCbbB2sCuzgQXY00l1UOF+POwdlXS9lwxybJ7o8qmkuNIt7AXmoBQRdWvJp keHr+YfQ52VKsIIUl+wldmHG7Ow7oYx8jUwIkGSqPoaXjR7qkZP74rGR4FWdasfhCPyI bbtg== X-Gm-Message-State: AGi0PuZn8W0wMKsWqCqNwN052/Lw/C+FXc1kKPRf5u7YzUq7r8iiH5V5 l4U5wBbrGI0QVFGtv5v6yiE= X-Google-Smtp-Source: APiQypK7Azz2+WxwoHE3rVYKcE7BGDyy2jhBIIpR257VCG9YgyRto2jm/uAjKMSpahuJrXm0uANnmA== X-Received: by 2002:a17:90a:fa0e:: with SMTP id cm14mr2871825pjb.92.1588162914403; Wed, 29 Apr 2020 05:21:54 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id h9sm966620pfo.129.2020.04.29.05.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 05:21:53 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 861A4403AB; Wed, 29 Apr 2020 12:21:52 +0000 (UTC) Date: Wed, 29 Apr 2020 12:21:52 +0000 From: Luis Chamberlain To: Christoph Hellwig Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Omar Sandoval , Hannes Reinecke , Michal Hocko , syzbot+603294af2d01acfdd6da@syzkaller.appspotmail.com Subject: Re: [PATCH v3 4/6] blktrace: fix debugfs use after free Message-ID: <20200429122152.GL11244@42.do-not-panic.com> References: <20200429074627.5955-1-mcgrof@kernel.org> <20200429074627.5955-5-mcgrof@kernel.org> <20200429112637.GD21892@infradead.org> <20200429114542.GJ11244@42.do-not-panic.com> <20200429115051.GA27378@infradead.org> <20200429120230.GK11244@42.do-not-panic.com> <20200429120406.GA913@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429120406.GA913@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 29, 2020 at 05:04:06AM -0700, Christoph Hellwig wrote: > On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote: > > > Err, that function is static and has two callers. > > > > Yes but that is to make it easier to look for who is creating the > > debugfs_dir for either the request_queue or partition. I'll export > > blk_debugfs_root and we'll open code all this. > > No, please not. exported variables are usually a bad idea. Just > skip the somewhat pointless trivial static function. Alrighty. It has me thinking we might want to only export those symbols to a specific namespace. Thoughts, preferences? BLOCK_GENHD_PRIVATE ? The scsi-generic driver seems... rather unique, and I'd imagine we'd want to discourage such concoctions in the future, so proliferations of these symbols. Luis