From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A588C83003 for ; Wed, 29 Apr 2020 12:48:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D7EE208FE for ; Wed, 29 Apr 2020 12:48:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="jGf2s8ig" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D7EE208FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1B148E0024; Wed, 29 Apr 2020 08:48:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA5078E0001; Wed, 29 Apr 2020 08:48:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A461E8E0024; Wed, 29 Apr 2020 08:48:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 8D8BC8E0001 for ; Wed, 29 Apr 2020 08:48:08 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5672A5DD6 for ; Wed, 29 Apr 2020 12:48:08 +0000 (UTC) X-FDA: 76760870256.11.seat94_4706c9b84f932 X-HE-Tag: seat94_4706c9b84f932 X-Filterd-Recvd-Size: 5827 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 12:48:07 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id g10so1506900lfj.13 for ; Wed, 29 Apr 2020 05:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wEMJoxtEGhfOvDBDbhs8bpCtdeQ7kpKFN9OKv+7KwjU=; b=jGf2s8igimnkwEt249ZxwqAlpJ8ImArLaLMkRKmTBXQVCH4csPw/nuaMOHblZlzfru mXQPpQT7gGp7ImtDy5KKaj16ZcWzQ7jeo8pK6aNkkMh6IyjEPRAiyetr6SwUNKKgVkUy B/tzR7hPuIdxSlqdCiuNKMoz0CkpjsAEnZL1Y38Zf/26aYHTSnH+saC4IycCYGCT4WgQ aCIVTqbLp6zzmSqFz0ojKGQXOQBbpRHs3mPdsynjCUKY96h0q/uoe/1sUosMn0cG7VEa SHwaL3mIvhsNFmyxd62+YUDKIw6NK78+KTe0InAyrDcy3Y+cxGwwXT+07ZnIrx6XGFfd xofQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wEMJoxtEGhfOvDBDbhs8bpCtdeQ7kpKFN9OKv+7KwjU=; b=fD3rLNdE8PEojmx8xZcMDyREdow0hNZqb4amTcrZWsldLekmhSbW+OBOx27vimYNfJ QZyNZSJyHK95KPbhm7KgJ5qjlVgz6O/ab1kyuUzIfPl4tz16s+fywwmcSSDSzTsMteD1 BWMfJCpCmFMWSo4pOYObPR+bGK2vlXLO6QlEXLVzMAmyl5X9r2tfH4mewz7Z/HqiIGi2 souepoKQrPXBxJmFPkgJ1dflHAQuOCZohAR/ohhlmZdPxSQ2qSe05ZcWW1Tz78am8KDb nzkmvv21AJjWOX1ZqDssR+l2fPkAdLy/4ejlRevdJxRDixYHBm1heCHGtNc3crIFZ4pL SUDw== X-Gm-Message-State: AGi0Puadha5uh4kfojGbBgX2eQXEcEVZm1si97nVknhzwvrsuv5FrtqB xZ/EP3fpMHjmDlNPdwvkIExCJwZNNaQ= X-Google-Smtp-Source: APiQypL5WvWcUGzFNMe6C0/RWBfvARXtEEZB9QTVjkVvvxOoX5+eIquA0CmMtpqEcuCR1pgCFGeyow== X-Received: by 2002:a19:c750:: with SMTP id x77mr22862637lff.1.1588164486075; Wed, 29 Apr 2020 05:48:06 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id k17sm2258839ljc.73.2020.04.29.05.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 05:48:05 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 5465E10235A; Wed, 29 Apr 2020 15:48:16 +0300 (+03) Date: Wed, 29 Apr 2020 15:48:16 +0300 From: "Kirill A. Shutemov" To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com Subject: Re: [PATCH] khugeepaged: Replace the usage of system(3) in the test. Message-ID: <20200429124816.jp272trghrzxx5j5@box> References: <20200429110727.89388-1-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429110727.89388-1-aneesh.kumar@linux.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 29, 2020 at 04:37:27PM +0530, Aneesh Kumar K.V wrote: > Some glibc version doesn't use CLONE_VM | CLONE_VFORK for system(3) implementation > and on such system, we find the test case fails. This is due to fork() marking > all the parent page table pages read-only to do a COW. > > Avoid the usage of system(3) in the test. > > Signed-off-by: Aneesh Kumar K.V Below is fixup for issues I've noticed. With them integrated the patch looks good to me and you can use my Acked-by: Kirill A. Shutemov diff --git a/tools/testing/selftests/vm/khugepaged.c b/tools/testing/selftests/vm/khugepaged.c index 9b2d675c0fd3..5d0698d4a101 100644 --- a/tools/testing/selftests/vm/khugepaged.c +++ b/tools/testing/selftests/vm/khugepaged.c @@ -345,7 +345,7 @@ static bool check_for_pattern(FILE *fp, char *pattern, char *buf) return false; } -static bool check_huge(char *addr) +static bool check_huge(void *addr) { bool thp = false; int ret; @@ -353,7 +353,8 @@ static bool check_huge(char *addr) char buffer[MAX_LINE_LENGTH]; char addr_pattern[MAX_LINE_LENGTH]; - ret = snprintf(addr_pattern, MAX_LINE_LENGTH, "%08llx-", addr); + ret = snprintf(addr_pattern, MAX_LINE_LENGTH, "%08lx-", + (unsigned long) addr); if (ret >= MAX_LINE_LENGTH) { printf("%s: Pattern is too long\n", __func__); exit(EXIT_FAILURE); @@ -368,7 +369,8 @@ static bool check_huge(char *addr) if (!check_for_pattern(fp, addr_pattern, buffer)) goto err_out; - ret = snprintf(addr_pattern, MAX_LINE_LENGTH, "AnonHugePages:%10lld kB", hpage_pmd_size >> 10); + ret = snprintf(addr_pattern, MAX_LINE_LENGTH, "AnonHugePages:%10ld kB", + hpage_pmd_size >> 10); if (ret >= MAX_LINE_LENGTH) { printf("%s: Pattern is too long\n", __func__); exit(EXIT_FAILURE); @@ -398,7 +400,8 @@ static bool check_swap(void *addr, unsigned long size) char buffer[MAX_LINE_LENGTH]; char addr_pattern[MAX_LINE_LENGTH]; - ret = snprintf(addr_pattern, MAX_LINE_LENGTH, "%08llx-", addr); + ret = snprintf(addr_pattern, MAX_LINE_LENGTH, "%08lx-", + (unsigned long) addr); if (ret >= MAX_LINE_LENGTH) { printf("%s: Pattern is too long\n", __func__); exit(EXIT_FAILURE); @@ -413,7 +416,8 @@ static bool check_swap(void *addr, unsigned long size) if (!check_for_pattern(fp, addr_pattern, buffer)) goto err_out; - ret = snprintf(addr_pattern, MAX_LINE_LENGTH, "Swap:%19lld kB", size >> 10); + ret = snprintf(addr_pattern, MAX_LINE_LENGTH, "Swap:%19ld kB", + size >> 10); if (ret >= MAX_LINE_LENGTH) { printf("%s: Pattern is too long\n", __func__); exit(EXIT_FAILURE); -- Kirill A. Shutemov