RE:[PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list

[Maninder Singh <maninder1.s@samsung.com>]

Hi,

>
>Acked-by: Michal Hocko <mhocko@suse.com>
>
>Is there any reason to move declarations here?
>

"unsigned int ret" was changed mistakenely, sending V2.
and "unsigned int nr_reclaimed" is changed to remove hole.
 
>> -unsigned long reclaim_clean_pages_from_list(struct zone *zone,
>> +unsigned int reclaim_clean_pages_from_list(struct zone *zone,
>>  					    struct list_head *page_list)
>>  {
>> +	unsigned int ret;
>>  	struct scan_control sc = {
>>  		.gfp_mask = GFP_KERNEL,
>>  		.priority = DEF_PRIORITY,
>>  		.may_unmap = 1,
>>  	};
>>  	struct reclaim_stat dummy_stat;
>> -	unsigned long ret;
>>  	struct page *page, *next;
>>  	LIST_HEAD(clean_pages);
>>  
>> @@ -1900,13 +1900,13 @@ static int current_may_throttle(void)
>>  {
>>  	LIST_HEAD(page_list);
>>  	unsigned long nr_scanned;
>> -	unsigned long nr_reclaimed = 0;
>>  	unsigned long nr_taken;
>>  	struct reclaim_stat stat;
>>  	int file = is_file_lru(lru);
>>  	enum vm_event_item item;
>>  	struct pglist_data *pgdat = lruvec_pgdat(lruvec);
>>  	struct zone_reclaim_stat *reclaim_stat = &lruvec->reclaim_stat;
>> +	unsigned int nr_reclaimed = 0;
>>  	bool stalled = false;
>>  
>>  	while (unlikely(too_many_isolated(pgdat, file, sc))) {


Thanks,
Maninder Singh