From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33478C83004 for ; Wed, 29 Apr 2020 13:37:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EDA24206D6 for ; Wed, 29 Apr 2020 13:37:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qCrRPIHx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDA24206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 54B008E000E; Wed, 29 Apr 2020 09:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27F398E0022; Wed, 29 Apr 2020 09:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2A0B8E0020; Wed, 29 Apr 2020 09:37:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id C63698E000E for ; Wed, 29 Apr 2020 09:37:00 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 822205825 for ; Wed, 29 Apr 2020 13:37:00 +0000 (UTC) X-FDA: 76760993400.29.money04_3d27555e8dd2b X-HE-Tag: money04_3d27555e8dd2b X-Filterd-Recvd-Size: 4319 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 13:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=dD9nVOWGwAdtF5Vt0w+D5s2gKPxSD7JmOgMrMrHOmY4=; b=qCrRPIHxRW2C6gHOXJ4gNEgiyR vm7stAoWsLW8IfULEpMH5myEpuebRP0N3F91RIZiT4qe2BwCcQ3WEXqvTQ9vEfGJ/P8bVQHCSJMxN V+73EcJ1HdFGw0l7/6qllJQsJOJg/QmTkMljkGy6ybFjgRcRRzQ0IEfm4hR+XOCFZnoeQfRL1kAON FpKSWUmy/XwSTnzT2wzaxleLVMwdoRtnSxA+LydioYq1kNJtFKHWOMaaU9HZksvFq8/n7BHbINvH4 OZi71+PWQJAXa8kRuRlGhNSs0SE35JbhKCJGVmQOGCMZ6+wxAe981DuMd6APSTyRxL8GehDnB1e4C mN9JiHIw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTmtX-0005vG-E0; Wed, 29 Apr 2020 13:36:59 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 10/25] iomap: Support arbitrarily many blocks per page Date: Wed, 29 Apr 2020 06:36:42 -0700 Message-Id: <20200429133657.22632-11-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200429133657.22632-1-willy@infradead.org> References: <20200429133657.22632-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" Size the uptodate array dynamically. Now that this array is protected by a spinlock, we can use bitmap functions to set the bits in this array instead of a loop around set_bit(). Signed-off-by: Matthew Wilcox (Oracle) --- fs/iomap/buffered-io.c | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 4bc37bf8d057..4a79061073eb 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -22,14 +22,14 @@ #include "../internal.h" =20 /* - * Structure allocated for each page when block size < PAGE_SIZE to trac= k + * Structure allocated for each page when block size < page size to trac= k * sub-page uptodate status and I/O completions. */ struct iomap_page { atomic_t read_count; atomic_t write_count; spinlock_t uptodate_lock; - DECLARE_BITMAP(uptodate, PAGE_SIZE / 512); + unsigned long uptodate[]; }; =20 static inline struct iomap_page *to_iomap_page(struct page *page) @@ -45,15 +45,14 @@ static struct iomap_page * iomap_page_create(struct inode *inode, struct page *page) { struct iomap_page *iop =3D to_iomap_page(page); + unsigned int nr_blocks =3D i_blocks_per_page(inode, page); =20 - if (iop || i_blocks_per_page(inode, page) <=3D 1) + if (iop || nr_blocks <=3D 1) return iop; =20 - iop =3D kmalloc(sizeof(*iop), GFP_NOFS | __GFP_NOFAIL); - atomic_set(&iop->read_count, 0); - atomic_set(&iop->write_count, 0); + iop =3D kzalloc(struct_size(iop, uptodate, BITS_TO_LONGS(nr_blocks)), + GFP_NOFS | __GFP_NOFAIL); spin_lock_init(&iop->uptodate_lock); - bitmap_zero(iop->uptodate, PAGE_SIZE / SECTOR_SIZE); =20 /* * migrate_page_move_mapping() assumes that pages with private data hav= e @@ -146,20 +145,12 @@ iomap_iop_set_range_uptodate(struct page *page, uns= igned off, unsigned len) struct iomap_page *iop =3D to_iomap_page(page); struct inode *inode =3D page->mapping->host; unsigned first =3D off >> inode->i_blkbits; - unsigned last =3D (off + len - 1) >> inode->i_blkbits; - bool uptodate =3D true; + unsigned count =3D len >> inode->i_blkbits; unsigned long flags; - unsigned int i; =20 spin_lock_irqsave(&iop->uptodate_lock, flags); - for (i =3D 0; i < i_blocks_per_page(inode, page); i++) { - if (i >=3D first && i <=3D last) - set_bit(i, iop->uptodate); - else if (!test_bit(i, iop->uptodate)) - uptodate =3D false; - } - - if (uptodate) + bitmap_set(iop->uptodate, first, count); + if (bitmap_full(iop->uptodate, i_blocks_per_page(inode, page))) SetPageUptodate(page); spin_unlock_irqrestore(&iop->uptodate_lock, flags); } --=20 2.26.2