From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D69C83009 for ; Wed, 29 Apr 2020 15:45:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB19320B80 for ; Wed, 29 Apr 2020 15:45:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="fj7G1yNM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB19320B80 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5CA558E0005; Wed, 29 Apr 2020 11:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 579FD8E0001; Wed, 29 Apr 2020 11:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 441428E0005; Wed, 29 Apr 2020 11:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id 2CC038E0001 for ; Wed, 29 Apr 2020 11:45:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E73213CE1 for ; Wed, 29 Apr 2020 15:45:33 +0000 (UTC) X-FDA: 76761317346.15.rat52_13701edf0f90a X-HE-Tag: rat52_13701edf0f90a X-Filterd-Recvd-Size: 4962 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 15:45:33 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id g10so2045796lfj.13 for ; Wed, 29 Apr 2020 08:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OKvac1bajpItzhuenoL2HhjmxuXDr5Pv3lediBuvToA=; b=fj7G1yNMGZ4U9adER/SwvrxROAJuHEUwx5/7bjSlCepoQn+CLaO3UAR5ooi49ffT28 LH8SJNVZ5+dXaFiRqscVxkwdEeobr6IOxd6iSLZlvIW/jnvDxoa7ro7AK9ByEzf3HWpn JJWo8iNIwQK3IlHBvFqAmC7IsgQ8/vfUJxOULOuRgH9PmCsvAzYleoc/ENnjJMODKUaE LPb7e4nudKBXnQxAJTrLUMtFgl/TCG026A7jHFR5RCQr45GK6A6KE1JbMoa7VRIjmXlc YYDJD1ux+paGDEFfmEdDyxXTuFkysOIGzN1CC2qB69legGjSa9PJSWP01LvxLfme/t+y /4xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OKvac1bajpItzhuenoL2HhjmxuXDr5Pv3lediBuvToA=; b=IF92lJJw55oQnOrJOKyOAuwOSb6QaGWMkQ2tg07odzJHgQPhn0e4CNPHoGEbDxudAj EGSnV8K9yee9272VltgXRgBBDOVE0asmXOyp5gQYjr/ff2O1dRA8+uLToJZxYcT94jfz 0bDOEKhSKOOsRcxzPmN4m0QzM1YumH9MQG+hs9gZGSj1h9/8U23EP+PCKCO8fwHtSiT+ zOnUelL2E3ehaO/bKQBPxNs3nGLrHxelA0Z4xSmu+0q6NJvVFg59tsq2LE23IdqdGMCU pPYZzKVB9hpqxelpjceqK3mULzV92wWrR5kMOOJPcy1IS98B64H3w021cT3vO47phlV+ 9MfQ== X-Gm-Message-State: AGi0PuavS93xcyjlrhH1lR977kL0yGAsEIE1bydDw6jyNKgsgGjt30RE P2tLTCHtnmaEyIO7Y255DPXicQ== X-Google-Smtp-Source: APiQypIrZoH6DqAujBzByLFpfg9w+AwrbJ28FDDtVgAMbJYdCn0iLRrLohVlWs/WetSSt7iE1U5ggw== X-Received: by 2002:ac2:57cb:: with SMTP id k11mr23290266lfo.19.1588175131830; Wed, 29 Apr 2020 08:45:31 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r12sm2447765ljc.12.2020.04.29.08.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 08:45:31 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 68BC21021F9; Wed, 29 Apr 2020 18:45:42 +0300 (+03) Date: Wed, 29 Apr 2020 18:45:42 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/25] Large pages in the page cache Message-ID: <20200429154542.kcqrtu3zrui5r6ah@box> References: <20200429133657.22632-1-willy@infradead.org> <20200429154002.n3mq2ysz37puf73y@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429154002.n3mq2ysz37puf73y@box> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 29, 2020 at 06:40:02PM +0300, Kirill A. Shutemov wrote: > On Wed, Apr 29, 2020 at 06:36:32AM -0700, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > This patch set does not pass xfstests. Test at your own risk. It is > > based on the readahead rewrite which is in Andrew's tree. The large > > pages somehow manage to fall off the LRU, so the test VM quickly runs > > out of memory and freezes. To reproduce: > > > > # mkfs.xfs /dev/sdb && mount /dev/sdb /mnt && dd if=/dev/zero bs=1M count=2048 of=/mnt/bigfile && sync && sleep 2 && sync && echo 1 >/proc/sys/vm/drop_caches > > # /host/home/willy/kernel/xarray-2/tools/vm/page-types | grep thp > > 0x0000000000401800 511 1 ___________Ma_________t____________________ mmap,anonymous,thp > > 0x0000000000405868 1 0 ___U_lA____Ma_b_______t____________________ uptodate,lru,active,mmap,anonymous,swapbacked,thp > > # dd if=/mnt/bigfile of=/dev/null bs=2M count=5 > > # /host/home/willy/kernel/xarray-2/tools/vm/page-types | grep thp > > 0x0000000000400000 2516 9 ______________________t____________________ thp > > 0x0000000000400028 1 0 ___U_l________________t____________________ uptodate,lru,thp > > 0x000000000040006c 106 0 __RU_lA_______________t____________________ referenced,uptodate,lru,active,thp > > Note that you have 107 pages on LRU. It is only head pages. With order-5 > pages it is over 13MiB. > > Looks like everything is fine. /proc/kpageflags reads page's flag bit directly instead of relying on PageLRU: u |= kpf_copy_bit(k, KPF_LRU, PG_lru); Tail pages don't have this bit set. They rely on head page's flag for PageLRU(). It would be nice to get it fixed, but I guess it is too late. Somebody may rely on the current behaviour by now. -- Kirill A. Shutemov