From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D79DC47253 for ; Thu, 30 Apr 2020 19:31:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C929924954 for ; Thu, 30 Apr 2020 19:31:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="vzffAZXt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C929924954 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C2BD8E0005; Thu, 30 Apr 2020 15:31:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 973AE8E0001; Thu, 30 Apr 2020 15:31:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8616E8E0005; Thu, 30 Apr 2020 15:31:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 6A0428E0001 for ; Thu, 30 Apr 2020 15:31:03 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 75864181AC9CC for ; Thu, 30 Apr 2020 19:31:02 +0000 (UTC) X-FDA: 76765514364.10.touch57_904afd15d851 X-HE-Tag: touch57_904afd15d851 X-Filterd-Recvd-Size: 3949 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Apr 2020 19:31:01 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id o10so6074887qtr.6 for ; Thu, 30 Apr 2020 12:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d1RAIbvoo2s7JffYGXt74NgzLodAkoT3ooI15LWHF58=; b=vzffAZXtvSvTwq5dKjdHWx63DCplLMxMCM5nmf/g/K/RG0YfleeYDmRvgKuHb4ZBAd w2YgrTnrZz0xNEdHNQvnr7Rr9/lSsOBtgCIVzJqTwCkFrrJTKZfScnqXAh9N/HKrOH5p KDqWBDqRw8t0gcyIWMhcT6dVIVWd5hyJ0rx8dtXwXNRdAbkhSU9h1IjLTpcwxaWWEZ2W j4Zq1oNj1y0SZjQ8iuchSaNHjfge8ycZcukkuoKnOhqvm6D39kHQPGmFg2cEjgxGWAI0 hvKc8DOcxkrD73j0wcVJDnqYPs/j7QqmM26IJdQVHb4T3TCVOqF6M9Jzr4l4JQqJO4lb SgXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d1RAIbvoo2s7JffYGXt74NgzLodAkoT3ooI15LWHF58=; b=fAUB7PVPjNBr89tx7lR+gv77N1xutDIzBYE7T1LzNaEClA0ulUL1zB9TbgGLjSO/I3 MH4Bv2WhP8SOA2oB6uL5ODSUe5ttM/0IfYvZmkoB2QlGnveBBQtaofUJ+jF/SMZHMCIc oxmLbwVODE1cXqJ+yzRk0a5fsXLbWdUynbLvvwYLcF9pmJmZBNj+ZjIeRfq02Fm1mGes /haNGwtOi1kJr/6gL1JQAv/G+SqI/lbJHyKc+J9exD2bHT89I8rT2wFx3qhLSsXCUv4k wg07L43yt0vAvoJ/9hMem661wrDu2rde2rQPgW+HTdUtdBKo9NGoW9ngapP0wHKHHExU NnDw== X-Gm-Message-State: AGi0PuZmDptLGmvO3IMgh1+pevoT08u1lJ93G9p87Y5XkKcfAdgXGvZW u4HlpltjpHvUixPRIp8yp6w/yw== X-Google-Smtp-Source: APiQypIx7o4Zv6JH1perddiK9QWDjW2RaNOmskvWp/qHUnEBVu3UEMz5Ag7jwSSF0QO4zYLd5nuZ3A== X-Received: by 2002:ac8:46d1:: with SMTP id h17mr92523qto.72.1588275061021; Thu, 30 Apr 2020 12:31:01 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:63a7]) by smtp.gmail.com with ESMTPSA id o43sm600444qtb.49.2020.04.30.12.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 12:31:00 -0700 (PDT) Date: Thu, 30 Apr 2020 15:30:49 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Shakeel Butt , Michal Hocko , Greg Thelen , Andrew Morton , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: oom: ignore oom warnings from memory.max Message-ID: <20200430193049.GB2436@cmpxchg.org> References: <20200430182712.237526-1-shakeelb@google.com> <20200430190610.GD339283@carbon.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430190610.GD339283@carbon.dhcp.thefacebook.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 30, 2020 at 12:06:10PM -0700, Roman Gushchin wrote: > On Thu, Apr 30, 2020 at 11:27:12AM -0700, Shakeel Butt wrote: > > @@ -6106,7 +6107,7 @@ static ssize_t memory_max_write(struct kernfs_open_file *of, > > } > > > > memcg_memory_event(memcg, MEMCG_OOM); > > - if (!mem_cgroup_out_of_memory(memcg, GFP_KERNEL, 0)) > > + if (!mem_cgroup_out_of_memory(memcg, GFP_KERNEL, 0, true)) > > I wonder if we can handle it automatically from the oom_killer side? > We can suppress warnings if oc->memcg is set and the cgroup scanning > showed that there are no belonging processes? Note that we do remote charging for certain consumers, where memory gets charged from the outside of the cgroup. We would want to know if these cause OOMs on an empty cgroup, rather than force-charge the allocations quietly.