From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EDBC47253 for ; Fri, 1 May 2020 10:55:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7536F2076D for ; Fri, 1 May 2020 10:55:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="I0/bGlBi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7536F2076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22C5E8E0015; Fri, 1 May 2020 06:55:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DBAB8E0001; Fri, 1 May 2020 06:55:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 118D48E0015; Fri, 1 May 2020 06:55:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EBEAC8E0001 for ; Fri, 1 May 2020 06:55:51 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8AF104DDD for ; Fri, 1 May 2020 10:55:51 +0000 (UTC) X-FDA: 76767844902.27.cook91_503a702f4491e X-HE-Tag: cook91_503a702f4491e X-Filterd-Recvd-Size: 3407 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 10:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=K4EvlvZJ7sfeaanlJ/LRWp5eylv34i1As4UZqRMOABw=; b=I0/bGlBitnCCFx6DOtfBMHHrR2 HIq5lUyjpiMWHo7whePAxr5+W4Vv/pg0XuBxeEZb38RUsg5O2/LRe8c2ZkjcNVd+UrVOmSr4KnBb3 OCab3mFcsTlCr9Q/hs+NGP0rwU+vGIpl+2AUDHxUM2p0aJb1XJsQ1MO6capHFDYpuJX8ANpMJ06+Z 9TYDFpG1PQkODYsOq8GlRNDvrMxPr7ECsiVWrfEnN2OXFgAf4XxlO4VccTiSxB56K/0CrGIMpqN4a 9Cl6le1pGZ+dUSVAGtkZxS2EdqoD2kvbcGtbrRxIVcGqRLKAoVg6uFX2v8CG2mnElRt8RTX7UxADR NmkUDrqA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUTKb-0002ee-Mk; Fri, 01 May 2020 10:55:45 +0000 Date: Fri, 1 May 2020 03:55:45 -0700 From: Christoph Hellwig To: Joonsoo Kim Cc: Andrew Morton , Linux Memory Management List , LKML , Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , kernel-team@lge.com, Christoph Hellwig , Joonsoo Kim Subject: Re: [PATCH v2 00/10] change the implementation of the PageHighMem() Message-ID: <20200501105545.GA29460@infradead.org> References: <1588130803-20527-1-git-send-email-iamjoonsoo.kim@lge.com> <20200429184711.9d603da097fdea80f574f1f1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 01, 2020 at 07:52:35PM +0900, Joonsoo Kim wrote: > > - New code will pop up which gets it wrong and nobody will notice for > > a long time. > > Hmm... I think that it's not that hard to decide correct macro. If we rename > PageHighMem() with PageDirectMapped(), they, PageDirectMapped() and > PageHighMemZone(), are self-explanation macro. There would be no > confusion to use. What confuses me is why we even need PageHighMemZone - mostly code should not care about particular zones. Maybe just open coding PageHighMemZone makes more sense - it is a little more cumersome, but at least it makes it explicit what we check for. I already sent you an incremental diff for one obvious place, but maybe we need to look through the remaining ones if we can kill them or open code them in an obvious way.